From owner-freebsd-threads@FreeBSD.ORG  Wed Sep 22 05:52:55 2004
Return-Path: <owner-freebsd-threads@FreeBSD.ORG>
Delivered-To: freebsd-threads@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id A395616A4CE; Wed, 22 Sep 2004 05:52:55 +0000 (GMT)
Received: from tts.orel.ru (tts.orel.ru [213.59.64.67])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id CCEBA43D48; Wed, 22 Sep 2004 05:52:54 +0000 (GMT)
	(envelope-from bel@orel.ru)
Received: from orel.ru (lg.orel.ru [62.33.11.59])
	by tts.orel.ru (8.12.10/8.12.10/bel) with ESMTP id i8M5qkeT014374;
	Wed, 22 Sep 2004 09:52:47 +0400
Message-ID: <4151132E.8030904@orel.ru>
Date: Wed, 22 Sep 2004 09:52:46 +0400
From: Andrew Belashov <bel@orel.ru>
Organization: ORIS
User-Agent: Mozilla/5.0 (X11; U; FreeBSD sparc64; en-US;
	rv:1.6) Gecko/20040407
X-Accept-Language: ru, en-us, en
MIME-Version: 1.0
To: freebsd-threads@freebsd.org
References: <Pine.GSO.4.43.0409211609030.26864-100000@sea.ntplx.net>
In-Reply-To: <Pine.GSO.4.43.0409211609030.26864-100000@sea.ntplx.net>
X-Enigmail-Version: 0.83.5.0
X-Enigmail-Supports: pgp-inline, pgp-mime
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Zombi-Check: on netra2.orel.ru
cc: Daniel Eischen <deischen@freebsd.org>
cc: Julian Elischer <julian@elischer.org>
Subject: Re: Bug in kse_switchin()?
X-BeenThere: freebsd-threads@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Threading on FreeBSD <freebsd-threads.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-threads>,
	<mailto:freebsd-threads-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-threads>
List-Post: <mailto:freebsd-threads@freebsd.org>
List-Help: <mailto:freebsd-threads-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-threads>,
	<mailto:freebsd-threads-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 22 Sep 2004 05:52:55 -0000

Daniel Eischen wrote:
 > On Tue, 21 Sep 2004, Julian Elischer wrote:
 >
 >>Andrew Belashov wrote:
 >>
 >>
 >>>See sys/kern/kern_kse.c
 >>>
 >>>In line with "suword32(&uap->tmbx->tm_lwp, td->td_tid)" kernel
 >>>not check return value (error state). This is correct?
 >>
 >>
 >>yes and no.
 >>
 >>You are correct.
 >>It is never correct to "not check" however we have just looked at that
 >>location 7 lines earlier, so we know
 >>that the page in question is loaded and valid. This is is "prbably safe".
 >>
 >>Probably we should look at the error value also, even if this is true.
 >
 >
 > Julian, you missed an important question below.  It looks
 > like he's trying to get this working with sparc64 and the
 > suword32 is generating an alignment exception.
 >
 > Is lwpid_t 64-bit on sparc64 or is it somehow not being aligned
 > properly within the mailbox?

lwpid_t on sparc64 is 32-bit (typedef __int32_t       __lwpid_t).

What about using copyout?

--
With best regards,
Andrew Belashov.