From owner-dev-commits-src-branches@freebsd.org Tue Apr 27 21:26:39 2021 Return-Path: Delivered-To: dev-commits-src-branches@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7A8CE622E26; Tue, 27 Apr 2021 21:26:39 +0000 (UTC) (envelope-from hps@selasky.org) Received: from mail.turbocat.net (turbocat.net [88.99.82.50]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4FVFFW2T9qz4vQr; Tue, 27 Apr 2021 21:26:38 +0000 (UTC) (envelope-from hps@selasky.org) Received: from hps2020.home.selasky.org (unknown [178.17.145.105]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id 2EAD0260195; Tue, 27 Apr 2021 23:26:37 +0200 (CEST) Subject: Re: An apology about my commits To: Neel Chauhan , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-branches@freebsd.org References: <6ae37bda99dfc279faff0ed0d50e3bfe@neelc.org> From: Hans Petter Selasky Message-ID: Date: Tue, 27 Apr 2021 23:25:21 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 MIME-Version: 1.0 In-Reply-To: <6ae37bda99dfc279faff0ed0d50e3bfe@neelc.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4FVFFW2T9qz4vQr X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-branches@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commits to the stable branches of the FreeBSD src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Apr 2021 21:26:39 -0000 On 4/27/21 12:53 AM, Neel Chauhan wrote: > Hi src committers, > > I hope all is well with you. > > I am really sorry about me prematurely pushing these MFC'ing these > linuxkpi commits to stable/13 instead of waiting out the three-day minimum: > > > Going forward, I will respect the 3 day waiting period for future src > commits. > > I hope you all have a great day. Hi Neel, All your patches were solid and reviewed by others and didn't break the builds. I would expect that the comments in differential were squashed together as a single patch before the commit. I personally use "env GIT_EDITOR=ee git rebase -i", and then change the word "pick" into "s" for squashing. The 3-day minimum waiting period is more or less to catch issues with the patches before they hit -stable branches. Only in rare cases I've seen exceptions, but I've never seen anyone loose their commit bits over that :-) So don't worry and sleep well. Keep up the good work in the LinuxKPI Neel! And if in doubt there are many active FreeBSD developers to ask before commit :-) --HPS > > Thank You, > > Neel Chauhan (nc@) > _______________________________________________ > dev-commits-src-all@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/dev-commits-src-all > To unsubscribe, send any mail to > "dev-commits-src-all-unsubscribe@freebsd.org"