From owner-svn-src-user@FreeBSD.ORG Sun Feb 24 19:49:03 2013 Return-Path: Delivered-To: svn-src-user@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 9B501673; Sun, 24 Feb 2013 19:49:03 +0000 (UTC) (envelope-from crees@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:1900:2254:2068::e6a:0]) by mx1.freebsd.org (Postfix) with ESMTP id 78814F7; Sun, 24 Feb 2013 19:49:03 +0000 (UTC) Received: from svn.freebsd.org ([127.0.1.70]) by svn.freebsd.org (8.14.5/8.14.5) with ESMTP id r1OJn31g062408; Sun, 24 Feb 2013 19:49:03 GMT (envelope-from crees@svn.freebsd.org) Received: (from crees@localhost) by svn.freebsd.org (8.14.5/8.14.5/Submit) id r1OJn3m6062407; Sun, 24 Feb 2013 19:49:03 GMT (envelope-from crees@svn.freebsd.org) Message-Id: <201302241949.r1OJn3m6062407@svn.freebsd.org> From: Chris Rees Date: Sun, 24 Feb 2013 19:49:03 +0000 (UTC) To: src-committers@freebsd.org, svn-src-user@freebsd.org Subject: svn commit: r247235 - user/crees/rclint X-SVN-Group: user MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-user@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the experimental " user" src tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 Feb 2013 19:49:03 -0000 Author: crees (ports committer) Date: Sun Feb 24 19:49:02 2013 New Revision: 247235 URL: http://svnweb.freebsd.org/changeset/base/247235 Log: Actually check shebang Modified: user/crees/rclint/rclint.py Modified: user/crees/rclint/rclint.py ============================================================================== --- user/crees/rclint/rclint.py Sun Feb 24 19:32:43 2013 (r247234) +++ user/crees/rclint/rclint.py Sun Feb 24 19:49:02 2013 (r247235) @@ -193,7 +193,7 @@ class Comment: class Shebang: def __init__(self, comment): self.line = comment.line - result = comment.match(r'#!(\S+)\s*(.*)') + result = comment.match(r'^#!(\S+)\s*(.*)') if result: self.value = result[0] self.args = result[1] @@ -323,7 +323,7 @@ def do_rclint(filename): logging.debug('OK, done collecting variables. Time to check!') logging.debug('Checking shebang') - if len(lineobj['Shebang']) < 1: + if lineobj['Shebang'][0].value == False: error.give('shebang') logging.debug('Checking RcsId')