From owner-freebsd-current@freebsd.org Thu Jul 25 19:18:41 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 16A02AC460; Thu, 25 Jul 2019 19:18:41 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 78FAE91466; Thu, 25 Jul 2019 19:18:40 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id x6PJIVPb029466 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Thu, 25 Jul 2019 22:18:35 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua x6PJIVPb029466 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id x6PJIVHq029465; Thu, 25 Jul 2019 22:18:31 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Thu, 25 Jul 2019 22:18:31 +0300 From: Konstantin Belousov To: Larry Rosenman Cc: Justin Hibbits , Alan Somers , Freebsd current , owner-freebsd-current@freebsd.org Subject: Re: [package - head-i386-default][sysutils/lsof] Failed for lsof-4.93.2_2,8 in build Message-ID: <20190725191831.GB2731@kib.kiev.ua> References: <201907251750.x6PHoAsV025165@beefy11.nyi.freebsd.org> <20190725134017.7c09692d@titan.knownspace> <6aa1650d276c1622ea9d66c2abe775a8@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6aa1650d276c1622ea9d66c2abe775a8@FreeBSD.org> User-Agent: Mutt/1.12.1 (2019-06-15) X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on tom.home X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Jul 2019 19:18:41 -0000 On Thu, Jul 25, 2019 at 02:10:46PM -0500, Larry Rosenman wrote: > On 07/25/2019 1:40 pm, Justin Hibbits wrote: > > On Thu, 25 Jul 2019 12:35:32 -0600 > > Alan Somers wrote: > > > >> On Thu, Jul 25, 2019 at 12:13 PM Larry Rosenman > >> wrote: > >> > > >> > On 07/25/2019 1:10 pm, Alan Somers wrote: > >> > > On Thu, Jul 25, 2019 at 12:05 PM Larry Rosenman > >> > > wrote: > >> > >> > >> > >> Um.... Who broke this? > > ... > >> > > "svn blame" suggests r350199 by kib. However, refcount.h should > >> > > only be included if lsof defines _KERNEL, which normal programs > >> > > shouldn't. So I think this should be considered a bug in lsof. > >> > > -Alan > >> > > >> > > >> > we *HAVE* to define _KERNEL, to get at the kernel structures..... > >> > >> Then I think you have to live with this amount of instability. > >> refcount(9) says that you should include . Did you do > >> that? If so, then this is a man page bug and refcount(9) should also > >> specify stdbool.h. > >> -Alan > > > > includes already, which typedefs bool. So > > should suffice to include in lsof. > > > > - Justin > > _______________________________________________ > > freebsd-current@freebsd.org mailing list > > https://lists.freebsd.org/mailman/listinfo/freebsd-current > > To unsubscribe, send any mail to > > "freebsd-current-unsubscribe@freebsd.org" > > Thanks all! I've got a PR into the lsof repo, and I'll fix it there. > > If we can't get a release out in the next day or 2, I'll patch it in the > port. > > https://github.com/lsof-org/lsof/pull/70 Absolutely minimal change to accomodate updated refcount.h would be inclusion of stdbool.h.