From owner-svn-src-projects@FreeBSD.ORG Wed Nov 18 17:02:53 2009 Return-Path: Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 888E21065670; Wed, 18 Nov 2009 17:02:53 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (skuns.zoral.com.ua [91.193.166.194]) by mx1.freebsd.org (Postfix) with ESMTP id F1C008FC17; Wed, 18 Nov 2009 17:02:52 +0000 (UTC) Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id nAIH2jvC076220 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 18 Nov 2009 19:02:46 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.3/8.14.3) with ESMTP id nAIH2jgY099893; Wed, 18 Nov 2009 19:02:45 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.3/8.14.3/Submit) id nAIH2j8D099892; Wed, 18 Nov 2009 19:02:45 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Wed, 18 Nov 2009 19:02:45 +0200 From: Kostik Belousov To: Nathan Whitehorn Message-ID: <20091118170245.GU2331@deviant.kiev.zoral.com.ua> References: <200911181645.nAIGjSJJ077790@svn.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="bWo1efE8ohP6g2nu" Content-Disposition: inline In-Reply-To: <200911181645.nAIGjSJJ077790@svn.freebsd.org> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: svn-src-projects@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r199486 - projects/ppc64/sys/compat/freebsd32 X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Nov 2009 17:02:53 -0000 --bWo1efE8ohP6g2nu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 18, 2009 at 04:45:27PM +0000, Nathan Whitehorn wrote: > Author: nwhitehorn > Date: Wed Nov 18 16:45:27 2009 > New Revision: 199486 > URL: http://svn.freebsd.org/changeset/base/199486 >=20 > Log: > Make several more freebsd32 syscalls work on big-endian hardware. > Statically linked 32-bit binaries now seem to work more or less perfect= ly > on a 64-bit kernel, but dynamically linked ones die in rtld with > EOVERFLOW. >=20 > Modified: > projects/ppc64/sys/compat/freebsd32/freebsd32_misc.c > projects/ppc64/sys/compat/freebsd32/freebsd32_proto.h >=20 > Modified: projects/ppc64/sys/compat/freebsd32/freebsd32_misc.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- projects/ppc64/sys/compat/freebsd32/freebsd32_misc.c Wed Nov 18 15:48= :51 2009 (r199485) > +++ projects/ppc64/sys/compat/freebsd32/freebsd32_misc.c Wed Nov 18 16:45= :27 2009 (r199486) > @@ -2100,8 +2100,13 @@ freebsd6_freebsd32_lseek(struct thread * > error =3D lseek(td, &ap); > /* Expand the quad return into two parts for eax and edx */ > pos =3D *(off_t *)(td->td_retval); > + #if BYTE_ORDER =3D=3D BIG_ENDIAN > + td->td_retval[0] =3D pos >> 32; > + td->td_retval[1] =3D pos & 0xffffffff; > + #else > td->td_retval[0] =3D pos & 0xffffffff; /* %eax */ > td->td_retval[1] =3D pos >> 32; /* %edx */ > + #endif > return error; > } What about defining constants like TD_RETVAL_HI and TD_RETVAL_LO, and then td->td_retval[TD_RETVAL_HI] =3D hiword; td->td_retval[TD_RETVAL_LO] =3D loword; There are several places in syscall return path in MD code that would also benefit from lesser amount of ifdef. --bWo1efE8ohP6g2nu Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (FreeBSD) iEYEARECAAYFAksEKLUACgkQC3+MBN1Mb4hYmQCcDbJENiRNi84ge+o8Jn9dXNkF /+sAn3jJT3BsDmM52Zps5DmW59vtWzlC =bpF5 -----END PGP SIGNATURE----- --bWo1efE8ohP6g2nu--