Date: Sat, 8 Jul 2023 17:10:38 +0100 From: Nuno Teixeira <eduardo@freebsd.org> To: Dimitry Andric <dim@freebsd.org> Cc: FreeBSD Mailing List <freebsd-ports@freebsd.org> Subject: Re: clang-tidy not part of base Message-ID: <CAFDf7UKUNBGv8ZtArDWQnHpEkvXQ=-aAvBHbnJC_qup0_9uWgg@mail.gmail.com> In-Reply-To: <DE9AD310-2FEB-467F-84E0-03905F2D69D4@FreeBSD.org> References: <CAFDf7UL1g41bDc3Zk9=oRAdMACLVUYCWQvBezcvWvEdhHQk=Bg@mail.gmail.com> <DE9AD310-2FEB-467F-84E0-03905F2D69D4@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--00000000000024e3ac05fffbfedb Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello Dimitry! Thanks for explanation. Having fun at https://github.com/aardappel/treesheets/pull/396 already. I digged at main src log and found that this tool have some importance: --- commit 711b35dc24a8165929a9402ff8406248b65467bc Author: Richard Yao <richard.yao@alumni.stonybrook.edu> Date: Fri Oct 14 22:46:43 2022 -0400 fm_fmri_hc_create() must call va_end() before returning clang-tidy caught this. (...) --- Cheers, Dimitry Andric <dim@freebsd.org> escreveu no dia s=C3=A1bado, 8/07/2023 =C3= =A0(s) 15:14: > On 8 Jul 2023, at 14:38, Nuno Teixeira <eduardo@freebsd.org> wrote: > > > > Recently deskutils/treesheets upstream introduced clang-tidy to cmake: > > --- > > set(CMAKE_CXX_CLANG_TIDY clang-tidy > -checks=3Dcppcoreguidelines-*,clang-analyzer-*,readability-*,performance-= *,portability-*,concurrency-*,modernize-*) > > --- > > > https://github.com/aardappel/treesheets/blob/9131048804169c448ba61900935f= f04acfb1e279/CMakeLists.txt#L63C13-L63C13 > > > > This causing build to fail because clang-tidy is not found. > > What I found is that 13 and 14 doesn't ship this program but it is > available as clang-tidy{13,15} from llvm ports. > > Theoretically we could import clang-tidy into base, at least the parts > that don't use Python, but it is better left in the llvm ports. > > > > As workaround I comment it out. > > Any sugestions on what to do, what to say to upstream? > > > > Should this be a cmake debug option? > > I guess that clang-tidy is used by the upstream maintainers, for cleaning > up the source, but it is of no use to ports builders or package end-users= . > > For the short term, I would simply comment it out. I would inform upstrea= m > that this can be problematic, and maybe put it under some sort of > "enable-maintainer-mode" option? > > -Dimitry > > --=20 Nuno Teixeira FreeBSD Committer (ports) --00000000000024e3ac05fffbfedb Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div>Hello Dimitry!</div><div><br></div><div>Thanks for ex= planation.<br></div><div>Having fun at <a href=3D"https://github.com/aardap= pel/treesheets/pull/396">https://github.com/aardappel/treesheets/pull/396</= a> already.</div><div><br></div><div>I digged at main src log and found tha= t this tool have some importance:</div><div>---</div><div>commit 711b35dc24= a8165929a9402ff8406248b65467bc<br>Author: Richard Yao <<a href=3D"mailto= :richard.yao@alumni.stonybrook.edu">richard.yao@alumni.stonybrook.edu</a>&g= t;<br>Date: =C2=A0 Fri Oct 14 22:46:43 2022 -0400<br><br>=C2=A0 =C2=A0 fm_f= mri_hc_create() must call va_end() before returning<br><br>=C2=A0 =C2=A0 cl= ang-tidy caught this.<br>(...)</div><div>---</div><div><br></div><div>Cheer= s,<br></div></div><br><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"= gmail_attr">Dimitry Andric <<a href=3D"mailto:dim@freebsd.org">dim@freeb= sd.org</a>> escreveu no dia s=C3=A1bado, 8/07/2023 =C3=A0(s) 15:14:<br><= /div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;bo= rder-left:1px solid rgb(204,204,204);padding-left:1ex">On 8 Jul 2023, at 14= :38, Nuno Teixeira <<a href=3D"mailto:eduardo@freebsd.org" target=3D"_bl= ank">eduardo@freebsd.org</a>> wrote:<br> > <br> > Recently deskutils/treesheets upstream introduced clang-tidy to cmake:= <br> > ---<br> > set(CMAKE_CXX_CLANG_TIDY clang-tidy -checks=3Dcppcoreguidelines-*,clan= g-analyzer-*,readability-*,performance-*,portability-*,concurrency-*,modern= ize-*)<br> > ---<br> > <a href=3D"https://github.com/aardappel/treesheets/blob/9131048804169c= 448ba61900935ff04acfb1e279/CMakeLists.txt#L63C13-L63C13" rel=3D"noreferrer"= target=3D"_blank">https://github.com/aardappel/treesheets/blob/91310488041= 69c448ba61900935ff04acfb1e279/CMakeLists.txt#L63C13-L63C13</a><br> > <br> > This causing build to fail because clang-tidy is not found.<br> > What I found is that 13 and 14 doesn't ship this program but it is= available as clang-tidy{13,15} from llvm ports.<br> <br> Theoretically we could import clang-tidy into base, at least the parts that= don't use Python, but it is better left in the llvm ports.<br> <br> <br> > As workaround I comment it out.<br> > Any sugestions on what to do, what to say to upstream?<br> > <br> > Should this be a cmake debug option?<br> <br> I guess that clang-tidy is used by the upstream maintainers, for cleaning u= p the source, but it is of no use to ports builders or package end-users.<b= r> <br> For the short term, I would simply comment it out. I would inform upstream = that this can be problematic, and maybe put it under some sort of "ena= ble-maintainer-mode" option?<br> <br> -Dimitry<br> <br> </blockquote></div><br clear=3D"all"><br><span class=3D"gmail_signature_pre= fix">-- </span><br><div dir=3D"ltr" class=3D"gmail_signature"><div dir=3D"l= tr"><span style=3D"color:rgb(102,102,102)">Nuno Teixeira<br>FreeBSD Committ= er (ports)</span></div></div> --00000000000024e3ac05fffbfedb--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFDf7UKUNBGv8ZtArDWQnHpEkvXQ=-aAvBHbnJC_qup0_9uWgg>