From owner-svn-src-head@freebsd.org Mon Mar 11 20:57:55 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5C946152E51A; Mon, 11 Mar 2019 20:57:55 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id EDF0B83503; Mon, 11 Mar 2019 20:57:54 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id D9BEC18397; Mon, 11 Mar 2019 20:57:54 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id x2BKvsFk012907; Mon, 11 Mar 2019 20:57:54 GMT (envelope-from imp@FreeBSD.org) Received: (from imp@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id x2BKvs5U012906; Mon, 11 Mar 2019 20:57:54 GMT (envelope-from imp@FreeBSD.org) Message-Id: <201903112057.x2BKvs5U012906@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: imp set sender to imp@FreeBSD.org using -f From: Warner Losh Date: Mon, 11 Mar 2019 20:57:54 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r345025 - head/sys/cam/scsi X-SVN-Group: head X-SVN-Commit-Author: imp X-SVN-Commit-Paths: head/sys/cam/scsi X-SVN-Commit-Revision: 345025 X-SVN-Commit-Repository: base MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: EDF0B83503 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-2.96 / 15.00]; local_wl_from(0.00)[FreeBSD.org]; NEURAL_HAM_MEDIUM(-1.00)[-0.995,0]; NEURAL_HAM_SHORT(-0.96)[-0.962,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; ASN(0.00)[asn:11403, ipnet:2610:1c1:1::/48, country:US] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Mar 2019 20:57:55 -0000 Author: imp Date: Mon Mar 11 20:57:54 2019 New Revision: 345025 URL: https://svnweb.freebsd.org/changeset/base/345025 Log: Upgrade Chipfancier SLC quirk to all versions The 16GB, 32GB and 128GB versions of this product all have the same problem. For some reason, the RC10 size is correct, while the RC16 size is larger (oddly by the capacity size / 1024 bytes). Using the RC16 size results in illegal LBA range errors when geom tastes the device. So, expand the quirk to cover all versions of this chip. Ideally, we'd get both READ CAPACITY 10 and READ CAPACITY 16 sizes and print a warnnig if they differ and use the smaller of the two numbers, though that may be problematical as well. Furthermore, SBC-4 encourages users transition to RC16 only, which suggests that in the future RC10 may disappear from some drives. It's unclear how to cope with these drives generically. PR: 234503 MFC After: 1 week Modified: head/sys/cam/scsi/scsi_da.c Modified: head/sys/cam/scsi/scsi_da.c ============================================================================== --- head/sys/cam/scsi/scsi_da.c Mon Mar 11 20:40:56 2019 (r345024) +++ head/sys/cam/scsi/scsi_da.c Mon Mar 11 20:57:54 2019 (r345025) @@ -865,11 +865,12 @@ static struct da_quirk_entry da_quirk_table[] = }, { /* - * 16GB SLC CHIPFANCIER - * PR: usb/234503 + * SLC CHIPFANCIER USB drives + * PR: usb/234503 (RC10 right, RC16 wrong) + * 16GB, 32GB and 128GB confirmed to have same issue */ - {T_DIRECT, SIP_MEDIA_REMOVABLE, "16G SLC", "CHIPFANCIER", - "1.00"}, /*quirks*/ DA_Q_NO_RC16 + {T_DIRECT, SIP_MEDIA_REMOVABLE, "*SLC", "CHIPFANCIER", + "*"}, /*quirks*/ DA_Q_NO_RC16 }, /* ATA/SATA devices over SAS/USB/... */ {