From owner-cvs-all@FreeBSD.ORG Fri Aug 13 22:51:23 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7A82316A4E9; Fri, 13 Aug 2004 22:51:23 +0000 (GMT) Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.126.188]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1087043D3F; Fri, 13 Aug 2004 22:51:23 +0000 (GMT) (envelope-from max@love2party.net) Received: from [212.227.126.179] (helo=mrelayng.kundenserver.de) by moutng.kundenserver.de with esmtp (Exim 3.35 #1) id 1BvktO-0002f2-00; Sat, 14 Aug 2004 00:51:22 +0200 Received: from [84.128.137.28] (helo=donor.laier.local) by mrelayng.kundenserver.de with asmtp (TLSv1:RC4-MD5:128) (Exim 3.35 #1) id 1BvktN-0001ak-00; Sat, 14 Aug 2004 00:51:22 +0200 From: Max Laier To: Robert Watson Date: Sat, 14 Aug 2004 00:49:25 +0200 User-Agent: KMail/1.6.2 References: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/signed; protocol="application/pgp-signature"; micalg=pgp-sha1; boundary="Boundary-02=_9VUHB6oxBbGSwSv"; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200408140049.33903.max@love2party.net> X-Provags-ID: kundenserver.de abuse@kundenserver.de auth:61c499deaeeba3ba5be80f48ecc83056 cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/net rtsock.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Aug 2004 22:51:23 -0000 --Boundary-02=_9VUHB6oxBbGSwSv Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Saturday 14 August 2004 00:37, Robert Watson wrote: > On Sat, 14 Aug 2004, Max Laier wrote: > > On Saturday 14 August 2004 00:23, Robert Watson wrote: > > > rwatson 2004-08-13 22:23:21 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > sys/net rtsock.c > > > Log: > > > Use IFQ_SET_MAXLEN() to set the maximum queue depth of the routing > > > socket netisr queue. > > > > Well, I suggest to use IFQ_* macros only on queues that are > > IFQ_SET_READY'ed as well. i.e. as long as you don't use IFQ_{EN,DE}QUEUE > > with the queue there is not much point in using IFQ_SET_MAXLEN either. > > It'd just add noise to searches for IFQ_* > > > > I don't think that there are plans to use ALTQ disciplines on the netisr > > queues, are there? > > No, that wouldn't really make sense, as we want a reliable record stream, > really, and the protocol in question wouldn't benefit from RED, etc. Do > you suggest, then, just backing this out? Some of the other ifq > abstractions are used, such as IFF_HANDOFF()... It does not hurt (much) to use IFQ_* macros on normal FIFO queues as long a= s=20 IFQ_SET_READY is not used to activate ALTQ processing. Nevertheless, there = is=20 some overhead and I don't see us removing the IF_* macros. So long story short: For normal FIFO queues use IF_* macros, for ALTQ-enabl= ed=20 queues use IFQ_* or IFQ_DRV_* (see altq(9) for details on the difference an= d=20 conversion). =2D-=20 /"\ Best regards, | mlaier@freebsd.org \ / Max Laier | ICQ #67774661 X http://pf4freebsd.love2party.net/ | mlaier@EFnet / \ ASCII Ribbon Campaign | Against HTML Mail and News --Boundary-02=_9VUHB6oxBbGSwSv Content-Type: application/pgp-signature Content-Description: signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.5 (FreeBSD) iD8DBQBBHUV9XyyEoT62BG0RAv0SAJ9FL4ijBGWaFnix1BzLWNiFPPOCQQCfTU5V f6G+8I27HgbWXpmjyWxGnFc= =sgwO -----END PGP SIGNATURE----- --Boundary-02=_9VUHB6oxBbGSwSv--