From owner-freebsd-mips@FreeBSD.ORG Mon Oct 10 19:59:12 2011 Return-Path: Delivered-To: freebsd-mips@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5DFBE1065670; Mon, 10 Oct 2011 19:59:12 +0000 (UTC) (envelope-from aduane@juniper.net) Received: from exprod7og114.obsmtp.com (exprod7og114.obsmtp.com [64.18.2.215]) by mx1.freebsd.org (Postfix) with ESMTP id 728798FC0A; Mon, 10 Oct 2011 19:59:08 +0000 (UTC) Received: from P-EMHUB01-HQ.jnpr.net ([66.129.224.36]) (using TLSv1) by exprod7ob114.postini.com ([64.18.6.12]) with SMTP; Mon, 10 Oct 2011 12:59:12 PDT Received: from p-emfe02-wf.jnpr.net (172.28.145.25) by P-EMHUB01-HQ.jnpr.net (172.24.192.35) with Microsoft SMTP Server (TLS) id 8.3.83.0; Mon, 10 Oct 2011 12:58:53 -0700 Received: from EMBX01-WF.jnpr.net ([fe80::1914:3299:33d9:e43b]) by p-emfe02-wf.jnpr.net ([fe80::c126:c633:d2dc:8090%11]) with mapi; Mon, 10 Oct 2011 15:58:52 -0400 From: Andrew Duane To: Adrian Chadd Date: Mon, 10 Oct 2011 15:58:51 -0400 Thread-Topic: svn commit: r225892 - head/sys/mips/mips Thread-Index: AcyGklSezZN0OmS6Q6yI/tX6hG8UNgA9HHjA Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "Jayachandran C." , Kostik Belousov , Alexander Motin , "freebsd-mips@freebsd.org" Subject: RE: svn commit: r225892 - head/sys/mips/mips X-BeenThere: freebsd-mips@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to MIPS List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Oct 2011 19:59:12 -0000 I'm not concerned with the size of the code per se. I'm concerned that some= day the code will change and no longer be 16 bytes, but the "16" won't get= changed on the other side. I've seen far too many cases of that over the y= ears. This could be handled by two matching comments, one in each place, or by so= me form of assert that the difference must be 16, or by computing the diffe= rence and using that as the "16". =A0................................... Andrew Duane Juniper Networks o=A0=A0=A0+1 978 589 0551 m=A0 +1 603-770-7088 aduane@juniper.net =A0 > -----Original Message----- > From: adrian.chadd@gmail.com [mailto:adrian.chadd@gmail.com] On Behalf > Of Adrian Chadd > Sent: Sunday, October 09, 2011 7:47 AM > To: Andrew Duane > Cc: Jayachandran C.; Warner Losh; Kostik Belousov; Alexander Motin; > freebsd-mips@freebsd.org > Subject: Re: svn commit: r225892 - head/sys/mips/mips >=20 > On 5 October 2011 01:49, Andrew Duane wrote: > > An assert, or some other check would work. Could you just add > "EndWaitSkip - StartWaitSkip" somehow? I just worry that some day it > won't be 16 bytes any more.... >=20 > Well, the linux code is 32 bytes rather than 16. >=20 > And it should be easy to extend the range to 32 bytes instead of 16 > bytes. >=20 > Unfortunately the patch doesn't (yet) work, I'm going to do some more > in depth testing next week. >=20 > Thanks, >=20 >=20 > Adrian