Date: Mon, 10 Oct 2011 15:58:51 -0400 From: Andrew Duane <aduane@juniper.net> To: Adrian Chadd <adrian@freebsd.org> Cc: "Jayachandran C." <jchandra@freebsd.org>, Kostik Belousov <kostikbel@gmail.com>, Alexander Motin <mav@freebsd.org>, "freebsd-mips@freebsd.org" <freebsd-mips@freebsd.org> Subject: RE: svn commit: r225892 - head/sys/mips/mips Message-ID: <AC6674AB7BC78549BB231821ABF7A9AEB80E5B7B76@EMBX01-WF.jnpr.net> In-Reply-To: <CAJ-Vmo=nSTSFH_NTP6%2BXu2TDgc%2BbO1YJ1NAPA8u%2BToMzk1nfSg@mail.gmail.com> References: <kor1ebmmdclae4u7bstwrc2c.1317741744919@email.android.com> <AC6674AB7BC78549BB231821ABF7A9AEB80CB1FE93@EMBX01-WF.jnpr.net> <CA%2B7sy7AncTdRDN88DaiPsBDc=PQ3N6UR9VAb7chOOp7XDXS=Sw@mail.gmail.com> <AC6674AB7BC78549BB231821ABF7A9AEB80CB20079@EMBX01-WF.jnpr.net> <CAJ-Vmo=nSTSFH_NTP6%2BXu2TDgc%2BbO1YJ1NAPA8u%2BToMzk1nfSg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
I'm not concerned with the size of the code per se. I'm concerned that some= day the code will change and no longer be 16 bytes, but the "16" won't get= changed on the other side. I've seen far too many cases of that over the y= ears. This could be handled by two matching comments, one in each place, or by so= me form of assert that the difference must be 16, or by computing the diffe= rence and using that as the "16". =A0................................... Andrew Duane Juniper Networks o=A0=A0=A0+1 978 589 0551 m=A0 +1 603-770-7088 aduane@juniper.net =A0 > -----Original Message----- > From: adrian.chadd@gmail.com [mailto:adrian.chadd@gmail.com] On Behalf > Of Adrian Chadd > Sent: Sunday, October 09, 2011 7:47 AM > To: Andrew Duane > Cc: Jayachandran C.; Warner Losh; Kostik Belousov; Alexander Motin; > freebsd-mips@freebsd.org > Subject: Re: svn commit: r225892 - head/sys/mips/mips >=20 > On 5 October 2011 01:49, Andrew Duane <aduane@juniper.net> wrote: > > An assert, or some other check would work. Could you just add > "EndWaitSkip - StartWaitSkip" somehow? I just worry that some day it > won't be 16 bytes any more.... >=20 > Well, the linux code is 32 bytes rather than 16. >=20 > And it should be easy to extend the range to 32 bytes instead of 16 > bytes. >=20 > Unfortunately the patch doesn't (yet) work, I'm going to do some more > in depth testing next week. >=20 > Thanks, >=20 >=20 > Adrian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AC6674AB7BC78549BB231821ABF7A9AEB80E5B7B76>