Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 02 Apr 1998 12:07:29 -0800 (PST)
From:      Simon Shapiro <shimon@simon-shapiro.org>
To:        se@FreeBSD.ORG, freebsd-ports@FreeBSD.ORG, jraynard@FreeBSD.ORG
Subject:   Minor Interaction Fix
Message-ID:  <XFMail.980402120729.shimon@simon-shapiro.org>

next in thread | raw e-mail | index | archive | help
/usr/ports/x11/kdelibs/work/kdelibs/khtmlwHi,

I am adding the list to this, as it may be interesting to other porters.

Once I installed sfio on my machine, certain applications fail to build.
For example kdelibs fails with:

Making all in khtmlw
/bin/sh ../libtool --mode=compile c++ -DHAVE_CONFIG_H -I. -I. -I..
-I../kdecore 
-I../kdeui -I../jscript -I/usr/local/include -I/usr/X11R6/include/X11/qt
-I/usr/
X11R6/include  -O -pipe -c jscript.cpp
c++ -DHAVE_CONFIG_H -I. -I. -I.. -I../kdecore -I../kdeui -I../jscript
-I/usr/loc
al/include -I/usr/X11R6/include/X11/qt -I/usr/X11R6/include -O -pipe -c
-fPIC -D
PIC jscript.cpp
/usr/local/include/sfio.h: In function `int sfgetc(struct _sfio_s *)':
In file included from /usr/local/include/stdio.h:11,
                 from jscript.cpp:21:
/usr/local/include/sfio.h:388: warning: `int sfgetc(struct _sfio_s *)' was
used 
before it was declared inline
/usr/local/include/sfio.h:308: warning: previous non-inline declaration here
/usr/X11R6/include/X11/qt/qglobal.h: At top level:
In file included from /usr/X11R6/include/X11/qt/qshared.h:26,
                 from /usr/X11R6/include/X11/qt/qgarray.h:26,
                 from /usr/X11R6/include/X11/qt/qarray.h:26,
                 from /usr/X11R6/include/X11/qt/qstring.h:27,
                 from jscript.h:23,
                 from jscript.cpp:23:
/usr/X11R6/include/X11/qt/qglobal.h:402: unrecognized format specifier for
`y#'
/usr/X11R6/include/X11/qt/qglobal.h:405: unrecognized format specifier for
`ä|#'
/usr/X11R6/include/X11/qt/qglobal.h:408: unrecognized format specifier for
`¨~#'

The way I solved that (which should not impact kdelibs, is to change, in 

    /usr/ports/x11/kdelibs/work/kdelibs/khtmlw/Makefile.in

Line 154, to say:

INCLUDES = -I/usr/include -I../kdecore -I../kdeui -I../jscript \
$(all_includes)  # All in one line :-)

I have no clue (did not look) why the failure occurs with the sfio includes
in the picture.

There are two suggestions I would like to make:

a.  It appears that -I in GCC, implies ``look there before the standard
    places''. Since, with sfio, we now have /usr/local/include/stdio.h (and
    others), we may want to pay attention to avoid its inclusion by mistake.

b.  If sfio is to live up to its claim of being a drop-in, it needs to make
    sure it really is a clean drop-in. The above case is a clear
    demonstration that, at least in FreeBSD 3.0-current, it is not.

I would love to pursue this matter further (being able to prove to David
Korn he has a bug is particularly satisfying :-).  Alas, I do nto have the
time.  Besides, the solutions are clear, but involve modifyingthe ports,
which I do not want to intrude upon.

Simon


----------


Sincerely Yours, 

Simon Shapiro
Shimon@Simon-Shapiro.ORG                      Voice:   503.799.2313

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.980402120729.shimon>