From nobody Sat May 23 23:20:20 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gNJ5x58rPz6f592; Sat, 23 May 2026 23:20:21 +0000 (UTC) (envelope-from des@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gNJ5x4FDTz3qqT; Sat, 23 May 2026 23:20:21 +0000 (UTC) (envelope-from des@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1779578421; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OrsAc1WcVxfny/+geXJr0zGVuwrsARk7D/qxdirObn8=; b=BhYe5oZbV1WgcicVxYoTcAcQ1pnQGauMbOr64tKfxSqFE64feY5hYqjjoSByxXMJHn/lEq umUasobMEgPS7DYIGOy0paGnGVkUNwlLfaULyyoz3GFhmLScRB+XZr1yIEFbduKURrTy6J xP13TzYy7WwwrjNWrFgJD2Uq2Wkn2vd/YgoaULNRAovycbhgOYUQaUO+d37PBFniynKLHZ yC3r4YFU9cGcqEpHWchqkjHblSQEngPeJG9sItKTspLoBudHY7VybIQE8mOwgGiN0VM81o x9MiVOh4aZ0DdsrdUrw1WmDKmAdxkduA9OemtU2ENi3aWNxBma3WNHz1l0KiAQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1779578421; a=rsa-sha256; cv=none; b=p+jJWbW24rL+uIcaMENB8M7gnRsz2Rjrh7GofdPzv411oobhHjSavPcWcybHUB1snpzQRj 3kjQ7BgL3iogymtzzymb9y73HX92rOpiBVh2KrzpYT2Tmu3OMV58FNcU3BSGvL77yRPnAp kyydS2DF3cdBtz9gppEHI+QC4sg6R14UStJcnGNyKROY50rgXIvDz2GPs0J9oZgWLtikNW KGnfJhE7tsp3nYbI20XcXWFFE8lI3oAJgbASYrK7pDqlGf/I4bLbhX0Yzn9D2PJVtPuZAU hennZYALcdHrf9/ETNlbn63imIhvmsKkIaYz/tzZn7yxgoTzRAnQLHFAk5GpIA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1779578421; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OrsAc1WcVxfny/+geXJr0zGVuwrsARk7D/qxdirObn8=; b=sXzFWzWeLevP2raCtgIa5zBan1woxikoMelmJxwjGFOjjtHKlWcDNJZFjfUDIiEkVezdmC uME+FDJXDedAzID89XIE+xIb+BNjC4OWZ37Q3xfyufMinalBVqF6IHS/Xez7yqq7IxbZqs 5zzwXhSkmEL8VrhFMQkPVQw+ixppGeiQNz8TnUJQJG8WzLYxE4TwN7RiEMSsgUhyUgk1v8 KXy9iSHAOuTyqvdlRfOzAHWL1hgLAkc0jpoTyPwx9/V9SlfXkZIXxydbj4mqCS9K2n/7qz qAT5ZUzu5DZmG1amkmMGvRX0PMJXk/7UgY58DCSRE5mP29dutHqqUDRGcZ30Sw== Received: from ltc.des.dev (unknown [92.183.12.56]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: des/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4gNJ5x2vFDzsV4; Sat, 23 May 2026 23:20:21 +0000 (UTC) (envelope-from des@freebsd.org) Received: by ltc.des.dev (Postfix, from userid 1001) id 370BF7273B; Sun, 24 May 2026 01:20:20 +0200 (CEST) From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= To: Jilles Tjoelker Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 1df431576f99 - main - sh/tests: Cut down builtins/read12.0 by 2 seconds In-Reply-To: <6a120625.45836.5e8588e2@gitrepo.freebsd.org> (Jilles Tjoelker's message of "Sat, 23 May 2026 19:55:17 +0000") References: <6a120625.45836.5e8588e2@gitrepo.freebsd.org> User-Agent: Gnus/5.13 (Gnus v5.13) Date: Sun, 24 May 2026 01:20:20 +0200 Message-ID: <86h5nx3e8b.fsf@ltc.des.dev> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Jilles Tjoelker writes: > commit 1df431576f99c3cc26dd4ceb1a6eda864cc9f196 > Author: Jilles Tjoelker > AuthorDate: 2026-05-23 19:47:15 +0000 > Commit: Jilles Tjoelker > CommitDate: 2026-05-23 19:47:15 +0000 > > sh/tests: Cut down builtins/read12.0 by 2 seconds >=20=20=20=20=20 > Since the test assumes a 250 ms response time, there is no need to de= lay > for 3 seconds. Instead, delay for the minimum possible 1 second. >=20=20=20=20=20 > Also, fix some assertions in builtins/read11.0 and builtins/read12.0.= If > `set -e` is in effect, `foo` in `foo && bar` is considered tested and > therefore a failure does not cause the shell to exit. >=20=20=20=20=20 > Reviewed by: bdrewery > Differential Revision: https://reviews.freebsd.org/D55191 I said no, several times. I also showed you how to speed up your tests by much more than thte two seconds you save here. Furthermore, I asked you several times to explain the login in this sentence: > Since the test assumes a 250 ms response time, there is no need to de= lay > for 3 seconds. Instead, delay for the minimum possible 1 second. and you were unable to. Please revert the non-functional parts of this change. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@FreeBSD.org