From nobody Fri Jul 31 10:58:39 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hBNNP5fC8z6n1b7 for ; Fri, 31 Jul 2026 10:58:45 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hBNNP3MVjz44Qf for ; Fri, 31 Jul 2026 10:58:45 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785495525; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=K7afbt0QVOAsNCgXPy+4jSCjzibZBBNAMTfK+nvmRWk=; b=Jz7n4v4STCVt93BLBqzobxIHRPc7IJoD5MdagKEUzdMuXMCPR5D3X7OVevqla9ZdUuZPYU dUEqWMQ9J1Pr3bAcCRsbjsUb+thuFI1Fm0csKKbI4R3Xac4xaUppnF/L5dfLBnG354y+45 fs7iZWgV4mFDmuk7Q0DdkZRGxamzxqxEXW9LtnlESZHDD9hloLaC4IYI9IjHdVBVtmToJ9 0GpgUNHDtvuRDDURsrV5a2fKULQnJd8Exb5wPNLwRttKYGp0ESaXXKchOPAtSTiOKxa4k8 jak+4kqo9MJuv6kJF01ypV05LztH3jQDeglrSmyArzpSUy9f5Y1Nelxr7B0iUg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1785495525; a=rsa-sha256; cv=none; b=J8kiVIMYrBV3v2M5w3ItC6lIlqkDCR0Yl7fcuQBO4pvcJOa9pafEdV+SSnxQNfh2z3r+6E g0Te5nzY7yid5qHSoK9EWa2GLps2V0nA59HKJNt8UGxkBKNmtF8Nky1zDR/g6gJqGspO15 4Algll5z1lA6LdstHb4QZ0MVX2CrwaPk4jsny7xvFdp2r8+oZ8MmCUcRn5W7EnZoBdIBAy 95SP4lkmZtT8ZsTKu+3moX7sHrBZ6Iy05OolrAdCeOwhhGwB/lgRnYhk0cHW3usU4+tVTf zAz4L2y6C2wcK9/rJk3tHnNRAaH9PqGtxSEydOAqjA19uhePAwAcvJIONhC3GA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785495525; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=K7afbt0QVOAsNCgXPy+4jSCjzibZBBNAMTfK+nvmRWk=; b=E6DCvllPhwTTxd5TNIXRqWg2F4A/1hm2XmHSfytjiUxJlK/Ha5mfBr0GsKjpuola/TcV7p mcf81hfw3SEmkx8S080Tx8/X5LNKm9aZz2u83djr+9bccAXYt9guwwAlx0KHdlZpVLmi+6 iAI73r+RE9ui618gHBAOsR6Lc3KK6HElzTugLhgYVKxAzpMXbw35Sy1utYo6a5SiDcwJTV MP5ywF2TiY0LKaORz7daq9Y49sIa7qzPzQTk7hHx2jktR9LL+bOW1NwiUDneUEX9MaMV1B nZmYeg+ILLUr9Kwiy7DiWvmvP2B9opFghT9Kp48yT7Rx87jjBUYttzZBuJSZtQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hBNNP1yspzwvD for ; Fri, 31 Jul 2026 10:58:45 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 39ad4 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 31 Jul 2026 10:58:39 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kevin Bowling Subject: git: 6020de5ad154 - main - ixv: fix multicast address enumeration List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 6020de5ad154d54c8b9a838f28612c2182330c67 Auto-Submitted: auto-generated Date: Fri, 31 Jul 2026 10:58:39 +0000 Message-Id: <6a6c7fdf.39ad4.c070c42@gitrepo.freebsd.org> The branch main has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=6020de5ad154d54c8b9a838f28612c2182330c67 commit 6020de5ad154d54c8b9a838f28612c2182330c67 Author: Kevin Bowling AuthorDate: 2026-07-28 11:06:23 +0000 Commit: Kevin Bowling CommitDate: 2026-07-31 10:56:15 +0000 ixv: fix multicast address enumeration if_foreach_llmaddr() adds each callback return value to its running count. Returning the incremented count made the address indices grow as 0, 1, 3, 7, and so on, eventually writing beyond the multicast address array. Return one address per callback and stop copying when the array is full, matching the ixv-1.6.12 driver. Fixes: ff06a8dbb677 ("Mechanically convert ixgbe(4) to IfAPI") MFC after: 1 week --- sys/dev/ixgbe/if_ixv.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/sys/dev/ixgbe/if_ixv.c b/sys/dev/ixgbe/if_ixv.c index 8a1c1aae041d..24e6fa714a7b 100644 --- a/sys/dev/ixgbe/if_ixv.c +++ b/sys/dev/ixgbe/if_ixv.c @@ -842,11 +842,14 @@ ixv_negotiate_api(struct ixgbe_softc *sc) static u_int ixv_if_multi_set_cb(void *cb_arg, struct sockaddr_dl *addr, u_int cnt) { + if (cnt >= MAX_NUM_MULTICAST_ADDRESSES) + return (0); + bcopy(LLADDR(addr), &((u8 *)cb_arg)[cnt * IXGBE_ETH_LENGTH_OF_ADDRESS], IXGBE_ETH_LENGTH_OF_ADDRESS); - return (++cnt); + return (1); } /************************************************************************ @@ -1982,4 +1985,3 @@ ixv_init_device_features(struct ixgbe_softc *sc) if (sc->feat_cap & IXGBE_FEATURE_NEEDS_CTXD) sc->feat_en |= IXGBE_FEATURE_NEEDS_CTXD; } /* ixv_init_device_features */ -