From owner-cvs-src@FreeBSD.ORG Tue Feb 8 03:51:34 2005 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E470916A4CE; Tue, 8 Feb 2005 03:51:34 +0000 (GMT) Received: from obsecurity.dyndns.org (CPE0050040655c8-CM00111ae02aac.cpe.net.cable.rogers.com [69.199.47.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id A2D5243D48; Tue, 8 Feb 2005 03:51:34 +0000 (GMT) (envelope-from kris@obsecurity.org) Received: by obsecurity.dyndns.org (Postfix, from userid 1000) id AC12351B2C; Mon, 7 Feb 2005 19:51:33 -0800 (PST) Date: Mon, 7 Feb 2005 19:51:33 -0800 From: Kris Kennaway To: Scott Long Message-ID: <20050208035133.GA32524@xor.obsecurity.org> References: <200502080343.j183h2Nt041950@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="OXfL5xGRrasGEqWY" Content-Disposition: inline In-Reply-To: <200502080343.j183h2Nt041950@repoman.freebsd.org> User-Agent: Mutt/1.4.2.1i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/twe twe.c twe_freebsd.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Feb 2005 03:51:35 -0000 --OXfL5xGRrasGEqWY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 08, 2005 at 03:43:02AM +0000, Scott Long wrote: > scottl 2005-02-08 03:43:02 UTC >=20 > FreeBSD src repository >=20 > Modified files: > sys/dev/twe twe.c twe_freebsd.c=20 > Log: > Fix crashdumps on twe. The twe_immediate_request() path was not only > copying data to a temporary buffer before the I/O, but also copying that > temporary buffer back to the original data location after the I/O. When > you're dumping kernel heap and stack and protected pages, this is very > very bad. > =20 > A belated thanks to Robert Watson for donating hardware for this (and f= uture) > work. Awesome! Kris --OXfL5xGRrasGEqWY Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.0 (FreeBSD) iD8DBQFCCDdFWry0BWjoQKURAnfZAJ4iw2XSIFJ62NCGMIMPeWbSzdrkMwCfal3S TNoBoCigtwglIx7bChL9zZ8= =78vD -----END PGP SIGNATURE----- --OXfL5xGRrasGEqWY--