Date: Sun, 15 Jan 2017 14:35:59 +0100 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Tijl Coosemans <tijl@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r431187 - in head/devel/dbus: . files Message-ID: <20170115133559.jdtblc7cwpobuq5x@ivaldir.etoilebsd.net> In-Reply-To: <20170115141445.7b58a649@kalimero.tijl.coosemans.org> References: <201701111507.v0BF7sXr024443@repo.freebsd.org> <20170114225816.zbx4lqxgof3zsfyq@ivaldir.etoilebsd.net> <20170115141445.7b58a649@kalimero.tijl.coosemans.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--emnrv7do3al3p43y Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jan 15, 2017 at 02:14:55PM +0100, Tijl Coosemans wrote: > On Sat, 14 Jan 2017 23:58:16 +0100 Baptiste Daroussin <bapt@FreeBSD.org> = wrote: > > On Wed, Jan 11, 2017 at 03:07:54PM +0000, Tijl Coosemans wrote: > >> -@dir /var/db/dbus > >> +@dir /var/lib/dbus > >> +@dir /var/lib > >> @dir /var/run/dbus > >> +@comment The following line may be removed after 2018-01-01 > >> +@postexec [ -f /var/lib/dbus/machine-id -o ! -f /var/db/dbus/machine-= id ] || cp -p /var/db/dbus/machine-id /var/lib/dbus/ > >=20 > > :( > >=20 > > I would have prefered a symlink rather this but hey (on FreeBSD /var/db > > is the right place in theory :)) >=20 > I'm really tired of FreeBSD putting files in different locations. It's > just more work and no benefit. Pain without gain. The right place is > whatever gives us, maintainers and users, the least amount of work. This > is a balancing exercise between maintainers that need to maintain the > hacks and patches and users that want to find certain files easily. So > for documentation I'm all for moving that to a consistent location, but > for runtime files /var/lib instead of /var/db is fine. >=20 > For the same reason I also still think we should move libdata/pkgconfig > to lib/pkgconfig. The pile of hacks and patches that could be removed > from the ports tree is truly immense and no user would ever realise it > or care about it. >=20 > Just take a look at this oneliner, think about the work it could save us > in the coming years and then please just commit it without hesitation :) I'm not portmgr anymore so I'm not the one to decide on that. While I tend = to agree with the pkgconfig thing you are proposing, I really dislike /var/lib= (but I won't fight against it.) about /var/lib there are not that many patches m= ostly a configure time option. but yes the issue there is mainly for compat with = linux binaries like the change you did. Such proposal should be validated imho with by portmgr imho. >=20 > Index: devel/pkgconf/Makefile > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- devel/pkgconf/Makefile (revision 431371) > +++ devel/pkgconf/Makefile (working copy) > @@ -2,6 +2,7 @@ > =20 > PORTNAME=3D pkgconf > PORTVERSION=3D 1.1.1 > +PORTREVISION=3D 1 > CATEGORIES=3D devel > MASTER_SITES=3D https://distfiles.dereferenced.org/pkgconf/ \ > http://files.etoilebsd.net/pkgconf/ > @@ -16,7 +17,7 @@ GNU_CONFIGURE=3D yes > INSTALL_TARGET=3D install-strip > USE_LDCONFIG=3D yes > TEST_TARGET=3D check > -CONFIGURE_ARGS=3D --with-pkg-config-dir=3D${PREFIX}/libdata/pkgconfig:/u= sr/libdata/pkgconfig \ > +CONFIGURE_ARGS=3D --with-pkg-config-dir=3D${PREFIX}/lib/pkgconfig:${PREF= IX}/libdata/pkgconfig:/usr/libdata/pkgconfig \ > --with-system-libdir=3D/usr/lib \ > --with-system-includedir=3D/usr/include > MAKE_ARGS=3D MANDIR=3D"${MAN1PREFIX}/man/man1" --emnrv7do3al3p43y Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEgOTj3suS2urGXVU3Y4mL3PG3PloFAlh7erwACgkQY4mL3PG3 PloxFw/8CEa8AaQ1cqkvdDf2anIbRkXLCGsw/yKvU6uP8lFQmtvpNZT2/Aby29Uv bA/9op3fUWdYT5nlvSdnsRcji+CNe23wsb+ILmLUtV1tWH9SRfDbE5Zosnqk+UD/ O5+QLd5mw9wD5BEo+/g2ioVZ24k8oZ4amFMSaWqmKSXJ4rQs5i2y9LYubRCbIGOm s9LsRxNW7zCYjpRfgRNleLRje3dpR+OMeYeLl53xrwTyVkXq6HB0ddhldMlnmKuR AzcrhWy/4Opg3dKOj7/RR2wPEgiGKMxfbtJQvnjJDvYRlL+zlQlqrcyDxbW6x1ZG IcXrGWTk5G95DE+YxanCRm8exS8FLOwJKVXXC3fZno9JKks4NYoPykc/8sQ9R0n5 HyWBCMNQ6l6fU/POapAi8rB8WGOf5APXwdvwlLQMiUElBzslVZpY0zDa758KA/AF JzOCYPyQtIS7L5NmDKlqSfWdUQtaHk9b9sUhzL3WZW+8avMvFCWKKw0ZffczrjMq OgSXCl0aYPR9Bl1scNWhKsyq/ZyRR/srXLRK4omq56yj+35ciKtjGln/QhHbqmPh ac74a4GHoRBdOdG9p66ctwvAoS4s58mqE58wXo/3S2xFKIcV9uu64rHWwQz8QR1+ jJguJluasyjFUU5pEqd8KpV+3MdoWcYT5MeGk1JtENZzU748/4o= =n0Yo -----END PGP SIGNATURE----- --emnrv7do3al3p43y--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170115133559.jdtblc7cwpobuq5x>