From owner-svn-ports-all@freebsd.org  Sat Apr 22 08:50:00 2017
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id DAFBDD4A119;
 Sat, 22 Apr 2017 08:50:00 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2610:1c1:1:6074::16:84])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id BAB8EA15;
 Sat, 22 Apr 2017 08:50:00 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1354)
 id E4A17729D; Sat, 22 Apr 2017 08:49:59 +0000 (UTC)
From: Jan Beich <jbeich@FreeBSD.org>
To: Ian Lepore <ian@freebsd.org>
Cc: Alan Somers <asomers@FreeBSD.org>,
 ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r439132 - in head/emulators/qemu-utils: . files
References: <201704212347.v3LNlSHX065826@repo.freebsd.org>
 <1492827032.56859.12.camel@freebsd.org>
Date: Sat, 22 Apr 2017 10:49:54 +0200
In-Reply-To: <1492827032.56859.12.camel@freebsd.org> (Ian Lepore's message of
 "Fri, 21 Apr 2017 20:10:32 -0600")
Message-ID: <fuh0-hln1-wny@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 22 Apr 2017 08:50:01 -0000

Ian Lepore <ian@freebsd.org> writes:

> On Fri, 2017-04-21 at 23:47 +0000, Alan Somers wrote:
>
>> Author: asomers (src committer)
>> Date: Fri Apr 21 23:47:27 2017
>> New Revision: 439132
>> URL: https://svnweb.freebsd.org/changeset/ports/439132
>> 
>> Log:
>>   Add missing file from r438925
>>   
>>   Apparently when you run "make makepatch" in a slave port, the patchfiles get
>>   put into the master port's directory
>
> If only there were a way that a slave port could have a whole directory
> full of extra patches and easily specify them to be applied along with
> the master's patches.
>
> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=193435

Interesting. Some ports worked around it via shell globbing e.g.,

  $ git grep 'EXTRA_PATCHES.*CURDIR.*\*'
  chinese/enscript/Makefile:EXTRA_PATCHES=	${.CURDIR}/files/patch-*
  devel/android-tools-adb-devel/Makefile:EXTRA_PATCHES=	${.CURDIR}/files/patch-*
  devel/android-tools-fastboot-devel/Makefile:EXTRA_PATCHES=	${.CURDIR}/files/patch-*
  japanese/plan/Makefile:EXTRA_PATCHES=	${.CURDIR}/files/patch-*

Index: emulators/qemu-utils/Makefile
===================================================================
--- emulators/qemu-utils/Makefile	(revision 439138)
+++ emulators/qemu-utils/Makefile	(working copy)
@@ -19,7 +19,7 @@ OPTIONS_EXCLUDE=	SAMBA X11 GTK2 OPENGL GNUTLS SASL
 MASTERDIR=	${.CURDIR}/../qemu
 PLIST=		${.CURDIR}/pkg-plist
 DESCR=		${.CURDIR}/pkg-descr
-EXTRA_PATCHES=	${.CURDIR}/files/patch-Makefile ${.CURDIR}/files/patch-configure
+EXTRA_PATCHES=	${.CURDIR}/files/patch-*
 PKGMESSAGE=
 
 PORTDOCS=	qemu-doc.html qmp-commands.txt