Date: Mon, 30 Sep 2019 07:24:29 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 240931] devel/arcanist: Exception when using with newer PHP Message-ID: <bug-240931-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D240931 Bug ID: 240931 Summary: devel/arcanist: Exception when using with newer PHP Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: Individual Port(s) Assignee: grembo@FreeBSD.org Reporter: lutz@donnerhacke.de Flags: maintainer-feedback?(grembo@FreeBSD.org) Assignee: grembo@FreeBSD.org Created attachment 207953 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D207953&action= =3Dedit utils/utils.php: patch to fix call oder Running arc on a newer version of PHP (i.e. 7.4) throws a lot of exceptions. This is currently a cosmetic issue, but will cause real errors in the futur= e. ``` [2019-09-30 07:00:39] ERROR 8192: implode(): Passing glue string after arra= y is deprecated. Swap the parameters at [/usr/local/lib/php/libphutil/src/utils/utils.php:1706] arcanist(), phutil() #0 implode(array, string) called at [<phutil>/src/utils/utils.php:1706] #1 phutil_build_http_querystring_from_pairs(array) called at [<phutil>/src/utils/utils.php:1678] #2 phutil_build_http_querystring(array) called at [<phutil>/src/future/http/HTTPSFuture.php:656] #3 HTTPSFuture::formatRequestDataForCURL() called at [<phutil>/src/future/http/HTTPSFuture.php:280] #4 HTTPSFuture::isReady() called at [<phutil>/src/future/Future.php:37] #5 Future::resolve(NULL) called at [<phutil>/src/future/FutureProxy.php:3= 4] #6 FutureProxy::resolve() called at [<phutil>/src/conduit/ConduitClient.php:64] #7 ConduitClient::callMethodSynchronous(string, array) called at [<arcanist>/src/workflow/ArcanistDiffWorkflow.php:518] #8 ArcanistDiffWorkflow::run() called at [<arcanist>/scripts/arcanist.php:394] ``` The documentation in https://www.php.net/manual/en/function.implode.php say= s: ``` implode ( string $glue , array $pieces ) : string Note: implode() can, for historical reasons, accept its parameters in either order. For consistency with explode(), however, it may be less confusing to use the documented order of arguments. ``` --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-240931-7788>