From nobody Sat Sep 20 06:16:32 2025 X-Original-To: freebsd-pkgbase@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cTJzx35Y1z68Kn4 for ; Sat, 20 Sep 2025 06:16:45 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mx.blih.net (mx.blih.net [212.83.155.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4cTJzw5Sb6z3c0K; Sat, 20 Sep 2025 06:16:44 +0000 (UTC) (envelope-from manu@bidouilliste.com) Authentication-Results: mx1.freebsd.org; none Received: from skull.home.blih.net (mwc0868.ftth.cust.milkywan.net [45.13.107.196]) by mx.blih.net (OpenSMTPD) with ESMTPSA id bd343a02 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sat, 20 Sep 2025 06:16:36 +0000 (UTC) Date: Sat, 20 Sep 2025 08:16:32 +0200 From: Emmanuel Vadot To: Lexi Winter Cc: Mark Millard , Baptiste Daroussin , FreeBSD-pkgbase@freebsd.org Subject: Re: An odd vital FreeBSD-set-* result? Message-Id: <20250920081632.bf262c28742cf9eb3ed9e31a@bidouilliste.com> In-Reply-To: References: <780BB42C-1EBE-4847-ADE6-F8F6730617B8.ref@yahoo.com> <780BB42C-1EBE-4847-ADE6-F8F6730617B8@yahoo.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; amd64-portbld-freebsd15.0) List-Id: Packaging the FreeBSD base system List-Archive: https://lists.freebsd.org/archives/freebsd-pkgbase List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-pkgbase@FreeBSD.org Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:12876, ipnet:212.83.128.0/19, country:FR] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4cTJzw5Sb6z3c0K On Fri, 19 Sep 2025 18:32:18 +0100 Lexi Winter wrote: > Mark Millard wrote in : > > But the following indicates that the cached *.pkg files themselves > > agree with the just-4-vitals status: > > do you build your packages with "make update-packages"? if so, can you > try deleting your ${REPODIR} and rebuilding, so all packages are > recreated? > > i'm wondering if adding the vital flag (but not changing anything else) > doesn't cause update-packages to actually update the package. Vital flag isn't taken into account for calculating the internal checksum (See https://github.com/freebsd/pkg/blob/main/libpkg/pkg_checksum.c#L197) we should probably add it there. Cheers, > > Also of note is the lack of a new-line between the prior } and the > > name: for most of the above. An example of a surrounding context is: > > > > categories: [ > > "base" > > ] > > annotations: { > > FreeBSD_version: "1600000" > > }name: "FreeBSD-set-base-dbg" > > origin: "base" > > it looks the UCL output from 'pkg info' doesn't have a trailing newline. > i think this is a pkg(8) bug, but it shouldn't have anything to do with > this issue. > > to confirm, this is the full output i get for the set-src package, using > 'echo' to force a trailing newline: > > # pkg info -R -F /build/packages/base/FreeBSD:16:amd64/latest/FreeBSD-set-src-16.snap20250919160159.pkg; echo > name: "FreeBSD-set-src" > origin: "base" > version: "16.snap20250919160159" > comment: "System source code" > maintainer: "re@FreeBSD.org" > www: "https://www.FreeBSD.org" > abi: "FreeBSD:16:amd64" > arch: "freebsd:16:x86:64" > prefix: "/" > flatsize: 0 > licenselogic: "single" > licenses: [ > "BSD2CLAUSE" > ] > vital: true > desc: "This metapackage installs source code for the base system and kernel." > deps: { > FreeBSD-src: { > origin: "base", > version: "16.snap20250919160159" > }, > FreeBSD-src-sys: { > origin: "base", > version: "16.snap20250919160159" > } > } > categories: [ > "base" > ] > annotations: { > FreeBSD_version: "1600000" > } > # > > other than the vital flag, does this match what you have? -- Emmanuel Vadot