From owner-svn-src-all@FreeBSD.ORG Fri Jul 5 20:37:00 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 99BA4B57; Fri, 5 Jul 2013 20:37:00 +0000 (UTC) (envelope-from nparhar@gmail.com) Received: from mail-lb0-x235.google.com (mail-lb0-x235.google.com [IPv6:2a00:1450:4010:c04::235]) by mx1.freebsd.org (Postfix) with ESMTP id 87EB711C8; Fri, 5 Jul 2013 20:36:59 +0000 (UTC) Received: by mail-lb0-f181.google.com with SMTP id w10so2312429lbi.40 for ; Fri, 05 Jul 2013 13:36:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=PvkIZwE0iru+nZu+Pgo52VYnLF5L4t1/sejWrvy/+FE=; b=lKHkloMWFg0YiIt4rWUaEBlp9ycUYLY1sJ58K2aUFfm3F2y2pg/5LAHGUdS2sW+cRh x9TQORgb0sQ+6TLBjpNMFA2EFSTdlLVyjlwUKVcD//+Vcg1nIwVQmd3JzFCwQFJEhv5V HPULEmjKEvEhrRTxzQtECyk4mwE91CB/kgdvqTnhrCp7bbVpq1yo4T6Hwn0dSXhNa+C9 dRKw1DE2bY1VF7h/gDSYPM5/Lxj+HtMyDccOpbaFSMys79tLgUauD4Rnb9vVI+JZsCUS JUIMb29Q4bK6+mVc8VWsJ5EGKKlpf0uMAsS7xNbCBQW+8RnOhVOePOl+Nfb05AocMlyF 1WAw== MIME-Version: 1.0 X-Received: by 10.112.51.99 with SMTP id j3mr6146798lbo.82.1373056618388; Fri, 05 Jul 2013 13:36:58 -0700 (PDT) Sender: nparhar@gmail.com Received: by 10.114.71.146 with HTTP; Fri, 5 Jul 2013 13:36:58 -0700 (PDT) In-Reply-To: <201307012221.r61MLhaM079236@svn.freebsd.org> References: <201307012221.r61MLhaM079236@svn.freebsd.org> Date: Fri, 5 Jul 2013 13:36:58 -0700 X-Google-Sender-Auth: 80x9oBSr3vx6E5plsL7TZyu6MUM Message-ID: Subject: Re: svn commit: r252491 - head/sys/modules From: Navdeep Parhar To: Robert Millan Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Jul 2013 20:37:00 -0000 This is a bit excessive. A better option would be to disconnect just the firmware based on the SOURCELESS flag. cxgbe(4) can be built and will work just fine without its firmware. The firmware is bundled with the driver just in case the one already on the card (every card has a firmware on it) is out of date. Regards, Navdeep On Mon, Jul 1, 2013 at 3:21 PM, Robert Millan wrote: > Author: rmh > Date: Mon Jul 1 22:21:42 2013 > New Revision: 252491 > URL: http://svnweb.freebsd.org/changeset/base/252491 > > Log: > Wrap cxgbe declaration around MK_SOURCELESS_UCODE check > > Modified: > head/sys/modules/Makefile > > Modified: head/sys/modules/Makefile > > ============================================================================== > --- head/sys/modules/Makefile Mon Jul 1 22:07:01 2013 (r252490) > +++ head/sys/modules/Makefile Mon Jul 1 22:21:42 2013 (r252491) > @@ -81,7 +81,7 @@ SUBDIR= \ > ${_ctau} \ > ctl \ > ${_cxgb} \ > - cxgbe \ > + ${_cxgbe} \ > ${_cyclic} \ > dc \ > dcons \ > @@ -386,6 +386,10 @@ _cxgb= cxgb > .endif > .endif > > +.if ${MK_SOURCELESS_UCODE} != "no" > +_cxgbe= cxgbe > +.endif > + > .if ${MK_CRYPT} != "no" || defined(ALL_MODULES) > .if exists(${.CURDIR}/../opencrypto) > _crypto= crypto >