Date: Sat, 10 Oct 2015 14:44:36 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: marino@freebsd.org Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r398971 - in head/audio/musescore: . files Message-ID: <20151010144435.GA90609@FreeBSD.org> In-Reply-To: <5618BFB3.2020905@marino.st> References: <201510100544.t9A5iZA2064835@repo.freebsd.org> <20151010070827.GA93698@FreeBSD.org> <5618BFB3.2020905@marino.st>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Oct 10, 2015 at 09:35:15AM +0200, John Marino wrote: > On 10/10/2015 9:08 AM, Alexey Dokuchaev wrote: > > On Sat, Oct 10, 2015 at 05:44:35AM +0000, John Marino wrote: > >> New Revision: 398971 > >> URL: https://svnweb.freebsd.org/changeset/ports/398971 > >> > >> [...] > >> + @${REINPLACE_CMD} -e \ > >> + 's|<errno.h>|<cerrno>| ; \ > >> + s|<limits.h>|<climits>| ; \ > >> + s|<math.h>|<cmath>| ; \ > >> + s|<stdio.h>|<cstdio>|' ${WRKSRC}/all.h > > > > I think these foo.h are missing escaping of the dot (should be foo\.h), no? > > Yes, but adding a slash doesn't change the result. It's a more correct > matching, but the current version is good enough (e.g. <errno.h> doesn't > match more than <errno\.h>) . In any case, it passed a build test. It's certainly works and is good enough, but seeing this mistake made often I'd wanted to point it out for educational purposes given chance. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20151010144435.GA90609>