From owner-cvs-all  Mon Aug 27  9:40: 5 2001
Delivered-To: cvs-all@freebsd.org
Received: from ipcard.iptcom.net (ipcard.iptcom.net [212.9.224.5])
	by hub.freebsd.org (Postfix) with ESMTP
	id F01AE37B405; Mon, 27 Aug 2001 09:39:50 -0700 (PDT)
	(envelope-from max@vega.com)
Received: from vega.vega.com (root@dialup10-47.iptelecom.net.ua [212.9.228.111])
	by ipcard.iptcom.net (8.9.3/8.9.3) with ESMTP id TAA96277;
	Mon, 27 Aug 2001 19:38:13 +0300 (EEST)
	(envelope-from max@vega.com)
Received: (from max@localhost)
	by vega.vega.com (8.11.4/8.11.3) id f7RGcCf49796;
	Mon, 27 Aug 2001 19:38:12 +0300 (EEST)
	(envelope-from sobomax@FreeBSD.org)
From: Maxim Sobolev <sobomax@FreeBSD.ORG>
Message-Id: <200108271638.f7RGcCf49796@vega.vega.com>
Subject: Re: cvs commit: src/sys/dev/md md.c
To: jhb@FreeBSD.ORG (John Baldwin)
Date: Mon, 27 Aug 2001 19:38:09 +0300 (EEST)
Cc: sobomax@FreeBSD.ORG (Maxim Sobolev), cvs-committers@FreeBSD.ORG,
	cvs-all@FreeBSD.ORG, dima@unixfreak.org ((Dima Dorfman))
In-Reply-To: <no.id> from "John Baldwin" at Aug 27, 2001 09:26:32 AM
X-Mailer: ELM [version 2.5 PL5]
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

> 
> 
> On 27-Aug-01 Maxim Sobolev wrote:
> >> 
> >> 
> >> On 27-Aug-01 Dima Dorfman wrote:
> >> > Maxim Sobolev <sobomax@FreeBSD.org> wrote:
> >> >> sobomax     2001/08/27 06:25:48 PDT
> >> >> 
> >> >>   Modified files:
> >> >>     sys/dev/md           md.c 
> >> >>   Log:
> >> >>   - On module unload try to detach all configured disks and let unload
> >> >>   proceed
> >> >>     if all disks were detached sucessfully;
> >> > 
> >> > I'm not sure this is wise.  More likely than not, trying to unload md
> >> > while there are still disks attached is a mistake on the user's part,
> >> > especially considering that most people aren't going to be loading and
> >> > unloading it on a regular basis.  I understand why this may be useful
> >> > for a developer working on md, but it seems counter-intuitive from a
> >> > regular user's perspective.
> >> 
> >> Yeah, I'd rather get an error (You're still using this stupid! *bonk*) like
> >> EBUSY or some such rather than have it do magical things for me behind my
> >> back.
> > 
> > Folks, have you tried to look into patches in question before commenting
> > on them (no pun intended)? As I said the driver will try to detach *idle*
> > disks only (i.e. configured but not opened), so they aren't really "in
> > use".
> 
> Erm, you said "all configured disks".  This does not clearly say "all configured
> but not opened disks".  An opened disk is obviously configured, so it easily
> fits in the set of all configured disks.  However, with the extra explanation,
> it now seems ok.

Plese forgeve me my pur Englesh skeels... ;)

-Maxim

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message