Date: Fri, 26 Apr 2013 22:15:32 +0200 From: Baptiste Daroussin <bapt@freebsd.org> To: Sunpoet Po-Chuan Hsieh <sunpoet@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers <ports-committers@freebsd.org> Subject: Re: svn commit: r316281 - head/Mk Message-ID: <20130426201532.GE74139@ithaqua.etoilebsd.net> In-Reply-To: <CAMHz58QUn76Q%2B=QJH7EWfOwHkAZywg4dzOMqvitf=V4w%2BNvDLw@mail.gmail.com> References: <201304222213.r3MMDFec026886@svn.freebsd.org> <CAMHz58QUn76Q%2B=QJH7EWfOwHkAZywg4dzOMqvitf=V4w%2BNvDLw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--C94crkcyjafcjHxo Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Apr 27, 2013 at 03:48:01AM +0800, Sunpoet Po-Chuan Hsieh wrote: > On Tue, Apr 23, 2013 at 6:13 AM, Baptiste Daroussin <bapt@freebsd.org>wro= te: >=20 > > Author: bapt > > Date: Mon Apr 22 22:13:14 2013 > > New Revision: 316281 > > URL: http://svnweb.freebsd.org/changeset/ports/316281 > > > > Log: > > Remove old links while creating the new packages > > Force creation of the symlink for pkgng to avoid failure if the link > > already exists > > > > Submitted by: ohauer@ > > > > Modified: > > head/Mk/bsd.pkgng.mk > > > > Modified: head/Mk/bsd.pkgng.mk > > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- head/Mk/bsd.pkgng.mk Mon Apr 22 22:06:34 2013 (r31628= 0) > > +++ head/Mk/bsd.pkgng.mk Mon Apr 22 22:13:14 2013 (r31628= 1) > > @@ -258,6 +258,9 @@ do-package: ${TMPPLIST} > > fi; \ > > fi; \ > > fi; > > + @for cat in ${CATEGORIES}; do \ > > + ${RM} -fv > > ${PACKAGES}/$$cat/${PKGNAMEPREFIX}${PORTNAME}*${PKG_SUFX} ; \ > > + done > > >=20 > Please revert/modify this change! > It has 2 problems. >=20 > First, it would remove other *correct* links. >=20 > % cd /usr/ports/x11/xorg > % make package > ... > =3D=3D=3D> Checking if x11/xorg already installed > =3D=3D=3D> Registering installation for xorg-7.5.2 > Installing xorg-7.5.2... done > =3D=3D=3D> Building package for xorg-7.5.2 > /usr/ports/packages/x11/xorg-7.5.2.txz > /usr/ports/packages/x11/xorg-cf-files-1.0.4.txz > /usr/ports/packages/x11/xorg-libraries-7.5.1.txz > /usr/ports/packages/x11/xorg-macros-1.16.1.txz > Creating package for xorg-7.5.2 This is not the problem but the goal with pkgng we need no more links anywh= ere except for pkgng itseld because the bootstrap in base relies on it. >=20 > Second, it's very strange to show some filenames/links without any > user-friendly messages. Users may not know that they are outdated links > removed by bsd.pkgng.mk. >=20 > e.g. while updating mail/postfix from 2.9.5 to 2.10, I got: > =3D=3D=3D> Building package for postfix-2.10.0,1 > /usr/ports/packages/mail/postfix-2.9.5,1.txz > /usr/ports/packages/ipv6/postfix-2.9.5,1.txz > Creating package for postfix-2.10.0,1 >=20 You are right here, I'll remove the -v. regards, Bapt --C94crkcyjafcjHxo Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlF64GMACgkQ8kTtMUmk6Eze7QCgoWIG8XOdvUiqrnx2bCmNh7NN FWgAoICwlOJI3bdSuh1Vgw3B8Ol7zZws =rlCx -----END PGP SIGNATURE----- --C94crkcyjafcjHxo--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130426201532.GE74139>