From owner-cvs-all@FreeBSD.ORG  Sat Jun 16 20:14:16 2007
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 816AE16A469
	for <cvs-all@FreeBSD.org>; Sat, 16 Jun 2007 20:14:16 +0000 (UTC)
	(envelope-from erwin@mail.droso.net)
Received: from mail.droso.net (koala.droso.net [193.88.12.38])
	by mx1.freebsd.org (Postfix) with ESMTP id 1E34613C43E
	for <cvs-all@FreeBSD.org>; Sat, 16 Jun 2007 20:14:15 +0000 (UTC)
	(envelope-from erwin@mail.droso.net)
Received: by mail.droso.net (Postfix, from userid 1001)
	id F036E1CCFF; Sat, 16 Jun 2007 22:14:14 +0200 (CEST)
Date: Sat, 16 Jun 2007 22:14:14 +0200
From: Erwin Lansing <erwin@FreeBSD.org>
To: Wilko Bulte <wb@freebie.xs4all.nl>
Message-ID: <20070616201414.GM90672@droso.net>
References: <200706161920.l5GJK2mk091919@repoman.freebsd.org>
	<46743999.3090505@samsco.org>
	<20070616200116.GA39011@freebie.xs4all.nl>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="7HHdeecsxVcUoH+o"
Content-Disposition: inline
In-Reply-To: <20070616200116.GA39011@freebie.xs4all.nl>
X-Operating-System: FreeBSD/i386 6.2-STABLE
User-Agent: Mutt/1.5.15 (2007-04-06)
Cc: cvs-src@FreeBSD.org, Scott Long <scottl@samsco.org>,
	src-committers@FreeBSD.org, Wilko Bulte <wilko@FreeBSD.org>,
	cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/dev/usb ukbd.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 16 Jun 2007 20:14:16 -0000


--7HHdeecsxVcUoH+o
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Jun 16, 2007 at 10:01:17PM +0200, Wilko Bulte wrote:
> On Sat, Jun 16, 2007 at 01:27:21PM -0600, Scott Long wrote..
> > Wilko Bulte wrote:
> > > wilko       2007-06-16 19:20:02 UTC
> > >=20
> > >   FreeBSD src repository
> > >=20
> > >   Modified files:
> > >     sys/dev/usb          ukbd.c=20
> > >   Log:
> > >   Per request (to core) by the person refered to in the comment.
> > >  =20
> > >   Revision  Changes    Path
> > >   1.65      +0 -2      src/sys/dev/usb/ukbd.c
> >=20
> > This commit message makes no sense.
>=20
> I removed the 2 lines with the guys name/email address.
>=20
Which wasn't clear from the commit message.  One needs to look up the
diff to find out *what* has happened while the commit message only
contains *why* it happened.  The commit message should include both.

"Remove comment per request (to core) from the person mentioned in it"

Cheers,
-erwin

--=20
Erwin Lansing                                     http://droso.org
Security is like an onion.          (o_ _o)
It's made up of several layers   \\\_\   /_///    erwin@FreeBSD.org
And it makes you cry.            <____) (____>    erwin@aauug.dk

--7HHdeecsxVcUoH+o
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (FreeBSD)

iD8DBQFGdESWqy9aWxUlaZARAvpyAJ923eYLQouBbkEceA58n/uu+BUasQCfYPr9
5fgF0RXbWUpBkTXXe2ckDBA=
=vCwk
-----END PGP SIGNATURE-----

--7HHdeecsxVcUoH+o--