From owner-svn-ports-all@FreeBSD.ORG  Wed Nov  6 05:19:13 2013
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
 id 17AEA9B5; Wed,  6 Nov 2013 05:19:13 +0000 (UTC)
Date: Wed, 6 Nov 2013 05:19:13 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Mark Felder <feld@FreeBSD.org>
Subject: Re: svn commit: r332417 - head/deskutils/tine20
Message-ID: <20131106051912.GA49604@FreeBSD.org>
References: <201311012241.rA1Mf9jY087068@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201311012241.rA1Mf9jY087068@svn.freebsd.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Nov 2013 05:19:13 -0000

On Fri, Nov 01, 2013 at 10:41:09PM +0000, Mark Felder wrote:
> New Revision: 332417
> URL: http://svnweb.freebsd.org/changeset/ports/332417
> 
>  do-install:
> -	${MKDIR} ${WWWDIR}
> -	@cd ${WRKSRC} && ${COPYTREE_SHARE} \* ${WWWDIR}
> +	${MKDIR} ${STAGEDIR}${WWWDIR}
> +	@cd ${WRKSRC} && ${COPYTREE_SHARE} \* ${STAGEDIR}${WWWDIR}

It is better to use dot (.) rather than shell globs (no need to worry
about escaping, looks more neat, etc.).  Dot is also recommented syntax
per PH (section 5.15.3).

./danfe