From owner-svn-ports-all@freebsd.org  Fri Apr 15 19:18:11 2016
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id F12E6AED7F8;
 Fri, 15 Apr 2016 19:18:11 +0000 (UTC) (envelope-from pi@FreeBSD.org)
Received: from fc.opsec.eu (fc.opsec.eu [IPv6:2001:14f8:200:4::4])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id B693A1519;
 Fri, 15 Apr 2016 19:18:11 +0000 (UTC) (envelope-from pi@FreeBSD.org)
Received: from pi by fc.opsec.eu with local (Exim 4.86_2 (FreeBSD))
 (envelope-from <pi@FreeBSD.org>)
 id 1ar9Fn-000IrL-4R; Fri, 15 Apr 2016 21:18:07 +0200
Date: Fri, 15 Apr 2016 21:18:07 +0200
From: Kurt Jaeger <pi@FreeBSD.org>
To: Alexey Dokuchaev <danfe@FreeBSD.org>
Cc: Kurt Jaeger <pi@FreeBSD.org>, ports-committers@freebsd.org,
 svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject: Re: svn commit: r413352 - in head/www/rt44: . files
Message-ID: <20160415191807.GD87626@fc.opsec.eu>
References: <201604151628.u3FGSuAC096464@repo.freebsd.org>
 <20160415170002.GA60195@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160415170002.GA60195@FreeBSD.org>
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 15 Apr 2016 19:18:12 -0000

Hi!

> On Fri, Apr 15, 2016 at 04:28:56PM +0000, Kurt Jaeger wrote:
> > New Revision: 413352
> > URL: https://svnweb.freebsd.org/changeset/ports/413352
> > 
> > Log:
> >   www/rt44: re-surrect as repo-copy of rt42
> >   
> >   PR:		208229
> >   Submitted by:	mat
> 
> PR 208229 was not submitted by mat@, please stop adding bogus attribution
> to commit logs.

The idea to re-do the commit as a repo-copy of rt42 is his
suggestion, and therefore...

> >  COMMENT=	RT is an industrial-grade ticketing system written in Perl
> 
> Violation of Section 5.6 of the PHB (clause #2).

Thanks, fixed.

> > @@ -90,7 +91,7 @@ SQLITE_RUN_DEPENDS=		${SQLITE_DEPS}
> >  
> >  DEVELOPER_DESC=			Configure for Developers
> >  DEVELOPER_RUN_DEPENDS=		${DEVELOPER_DEPS}
> 
> Wrong spelling, "developers" is not a proper noun and should not be
> capitalized.

Fixed.

> >  SMIME_DESC=			Enable Secure MIME support
> 
> Also wrong, correct version of SMIME_DESC is "Secure MIME support".

Fixed.

> > ---- ./Makefile.in.orig	2014-05-06 17:59:04.000000000 +0100
> > -+++ ./Makefile.in	2014-05-14 15:26:37.708277377 +0100
> > +--- ./Makefile.in.orig	2014-05-06 17:59:04 UTC
> > ++++ ./Makefile.in
> 
> That's weird: looks like patches were (re)generated by `make makepatch`,
> but still contain bogus leading `./' in the filenames.

Good question, I don't know why this happens like that.

-- 
pi@FreeBSD.org         +49 171 3101372                4 years to go !