From owner-svn-src-head@FreeBSD.ORG  Mon Nov  8 20:11:43 2010
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 6B2A81065675;
	Mon,  8 Nov 2010 20:11:43 +0000 (UTC) (envelope-from obrien@NUXI.org)
Received: from dragon.nuxi.org (trang.nuxi.org [74.95.12.85])
	by mx1.freebsd.org (Postfix) with ESMTP id 07C028FC2E;
	Mon,  8 Nov 2010 20:11:43 +0000 (UTC)
Received: from dragon.nuxi.org (obrien@localhost [127.0.0.1])
	by dragon.nuxi.org (8.14.4/8.14.4) with ESMTP id oA8KBgaD090910;
	Mon, 8 Nov 2010 12:11:42 -0800 (PST)
	(envelope-from obrien@dragon.nuxi.org)
Received: (from obrien@localhost)
	by dragon.nuxi.org (8.14.4/8.14.4/Submit) id oA8KBgo6090909;
	Mon, 8 Nov 2010 12:11:42 -0800 (PST) (envelope-from obrien)
Date: Mon, 8 Nov 2010 12:11:42 -0800
From: "David O'Brien" <obrien@FreeBSD.org>
To: Juli Mallett <jmallett@FreeBSD.org>
Message-ID: <20101108201142.GB90846@dragon.NUXI.org>
References: <201011072322.oA7NMhb0092364@svn.freebsd.org>
	<AANLkTi=zKy++q2DLreKR6Gt4ykTKfjymO7f47pG-jH0A@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=unknown-8bit
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <AANLkTi=zKy++q2DLreKR6Gt4ykTKfjymO7f47pG-jH0A@mail.gmail.com>
X-Operating-System: FreeBSD 9.0-CURRENT
X-to-the-FBI-CIA-and-NSA: HI! HOW YA DOIN?
User-Agent: Mutt/1.5.16 (2007-06-09)
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
	src-committers@FreeBSD.org
Subject: Re: svn commit: r214961 - head/usr.bin/yacc
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: obrien@FreeBSD.org
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 08 Nov 2010 20:11:43 -0000

On Sun, Nov 07, 2010 at 05:54:20PM -0800, Juli Mallett wrote:
> On Sun, Nov 7, 2010 at 15:22, David E. O'Brien <obrien@freebsd.org> wrote:
> > Author: obrien
> > Date: Sun Nov  7 23:22:42 2010
> > New Revision: 214961
> > URL: http://svn.freebsd.org/changeset/base/214961
> >
> > Log:
> >  Directly use memory allocation functions and remove needless casts in
> >  their usage.  Also use associated modern types instead of k&r ones.
> 
> You do know that changing skeleton.c affects the generated files,
> right?

Yes Juli, I know how byacc works.

> I'm wondering if whatever sed script you're
> judiciously-applying knows that.  C++ does not do implicit conversions
> from "void *" so you need the casts on the mallocs there.

The changes I made were tested on building several other applications.

> With a C++ compiler:

But as you indirectly point out -- they were all C applications.

-- 
-- David  (obrien@FreeBSD.org)