From owner-freebsd-ports@FreeBSD.ORG  Wed Jun  2 06:44:06 2004
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 2D7ED16A4CE
	for <ports@FreeBSD.org>; Wed,  2 Jun 2004 06:44:05 -0700 (PDT)
Received: from mtaw4.prodigy.net (mtaw4.prodigy.net [64.164.98.52])
	by mx1.FreeBSD.org (Postfix) with ESMTP id B796E43D2D
	for <ports@FreeBSD.org>; Wed,  2 Jun 2004 06:44:05 -0700 (PDT)
	(envelope-from kris@obsecurity.org)
Received: from obsecurity.dyndns.org
	(778bd9c50b26b073125a49fe44e95c4c@adsl-67-115-73-128.dsl.lsan03.pacbell.net
	[67.115.73.128])
	by mtaw4.prodigy.net (8.12.10/8.12.10) with ESMTP id i52DhgfY011724;
	Wed, 2 Jun 2004 06:43:42 -0700 (PDT)
Received: by obsecurity.dyndns.org (Postfix, from userid 1000)
	id 09F2652698; Wed,  2 Jun 2004 06:43:41 -0700 (PDT)
Date: Wed, 2 Jun 2004 06:43:40 -0700
From: Kris Kennaway <kris@obsecurity.org>
To: Oliver Eikemeier <eikemeier@fillmore-labs.com>
Message-ID: <20040602134340.GA55881@xor.obsecurity.org>
References: <20040602121648.GA51625@xor.obsecurity.org>
	<40BDCC4B.9000708@fillmore-labs.com>
	<20040602132149.GA55452@xor.obsecurity.org> <40BDD8B6.80103@fillmore-labs.com>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="r5Pyd7+fXNt84Ff3"
Content-Disposition: inline
In-Reply-To: <40BDD8B6.80103@fillmore-labs.com>
User-Agent: Mutt/1.4.2.1i
cc: ports@FreeBSD.org
cc: Kris Kennaway <kris@obsecurity.org>
Subject: Re: INDEX patch
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 02 Jun 2004 13:44:06 -0000


--r5Pyd7+fXNt84Ff3
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Jun 02, 2004 at 03:40:06PM +0200, Oliver Eikemeier wrote:
> Kris Kennaway wrote:
>=20
> >On Wed, Jun 02, 2004 at 02:47:07PM +0200, Oliver Eikemeier wrote:
> >
> >>Kris Kennaway wrote:
> >>
> >>
> >>>A previous commit to bsd.port.mk broke the reporting of missing
> >>>dependencies from 'make index'.  This patch restores it (and makes
> >>>these errors fatal).  I plan to commit it soon.
> >>>
> >>>Kris
> >>
> >>May I suggest the following patch:
> >>
> >>- check for existence of perl (cf. my RFC on ports-developers)
> >>- enables the use of `env PATH=3D /usr/bin/make describe' (nice for tes=
ting)
> >
> >Nice idea, but running this test 11000 times is suboptimal :-)
>=20
> Because test is a sh-builtin, and the file system should cache this=20
> information
> I don't expect to see any difference. Especially since spawning perl 1100=
0=20
> times
> is more than suboptimal ;) You didn't mean this serious, did you?

I did, because I care about small pessimizations of the INDEX build.
Sometimes they're not small.  Did you benchmark it?

Kris
--r5Pyd7+fXNt84Ff3
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (FreeBSD)

iD8DBQFAvdmMWry0BWjoQKURArURAKCIoD2cMCUk4VGOORGjpQbIerXvQgCglEmf
uSc62ry7nItBaD61lc+JbOc=
=7fcS
-----END PGP SIGNATURE-----

--r5Pyd7+fXNt84Ff3--