From owner-freebsd-hackers Sun Feb 11 22:26:12 2001 Delivered-To: freebsd-hackers@freebsd.org Received: from urban.iinet.net.au (urban.iinet.net.au [203.59.24.231]) by hub.freebsd.org (Postfix) with ESMTP id 5973E37B491; Sun, 11 Feb 2001 22:26:05 -0800 (PST) Received: from muzak.iinet.net.au (muzak.iinet.net.au [203.59.24.237]) by urban.iinet.net.au (8.8.7/8.8.7) with ESMTP id OAA14774; Mon, 12 Feb 2001 14:26:04 +0800 Received: from elischer.org (reggae-15-178.nv.iinet.net.au [203.59.74.178]) by muzak.iinet.net.au (8.8.5/8.8.5) with ESMTP id OAA24252; Mon, 12 Feb 2001 14:23:27 +0800 Message-ID: <3A8781EE.8AEA1351@elischer.org> Date: Sun, 11 Feb 2001 22:25:50 -0800 From: Julian Elischer X-Mailer: Mozilla 4.7 [en] (X11; U; FreeBSD 5.0-CURRENT i386) X-Accept-Language: en, hu MIME-Version: 1.0 To: Bill Paul Cc: Archie Cobbs , hackers@FreeBSD.ORG, net@FreeBSD.ORG Subject: Re: call for testers: port aggregation netgraph module References: <20010212025610.F37C937B401@hub.freebsd.org> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Bill Paul wrote: > one other thing.. In ng_fec.h you have kept the same cookie number as ng_iface which means that messages for these two can be confused. You should use a differnt cookie by tradition we use date -u +'%s' to generate or change the cookie. Since the first 3 commands you have are actually the same as the first 3 commands from ng_iface, you might actually think of using them direct and actually implementing them directly rather than duplicating them. i.e, include ng_iface.h, and accept 'ng_iface' cookies and respond to those commands rather than have them as part of your own set. (this makes an fec interface in some ways a 'sub-class' of the generic interface node type) -- __--_|\ Julian Elischer / \ julian@elischer.org ( OZ ) World tour 2000-2001 ---> X_.---._/ v To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message