Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 11 Feb 2001 22:25:50 -0800
From:      Julian Elischer <julian@elischer.org>
To:        Bill Paul <wpaul@FreeBSD.ORG>
Cc:        Archie Cobbs <archie@dellroad.org>, hackers@FreeBSD.ORG, net@FreeBSD.ORG
Subject:   Re: call for testers: port aggregation netgraph module
Message-ID:  <3A8781EE.8AEA1351@elischer.org>
References:  <20010212025610.F37C937B401@hub.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Bill Paul wrote:
> 
one other thing..

In ng_fec.h you have kept the same cookie number as ng_iface
which means that messages for these two can be confused.

You should use a differnt cookie

by tradition we use date -u +'%s'
to generate or change the cookie.

Since the first 3 commands you have are actually the same as
the first 3 commands from ng_iface, you might actually think of using them
direct
and actually implementing them directly rather than duplicating them.
i.e, include ng_iface.h, and accept 'ng_iface' cookies and respond to those 
commands rather than have them as part of your own set.
(this makes an fec interface in some ways a 'sub-class' of the generic
interface node type)

-- 
      __--_|\  Julian Elischer
     /       \ julian@elischer.org
    (   OZ    ) World tour 2000-2001
---> X_.---._/  
            v


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3A8781EE.8AEA1351>