From owner-svn-src-head@FreeBSD.ORG  Tue Aug 21 05:46:19 2012
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 7DECB1065670;
	Tue, 21 Aug 2012 05:46:19 +0000 (UTC) (envelope-from sjg@juniper.net)
Received: from exprod7og103.obsmtp.com (exprod7og103.obsmtp.com [64.18.2.159])
	by mx1.freebsd.org (Postfix) with ESMTP id 917488FC08;
	Tue, 21 Aug 2012 05:46:18 +0000 (UTC)
Received: from P-EMHUB02-HQ.jnpr.net ([66.129.224.36]) (using TLSv1) by
	exprod7ob103.postini.com ([64.18.6.12]) with SMTP
	ID DSNKUDMgpHbMqLallxOpNXEijuwq14MGlv3h@postini.com;
	Mon, 20 Aug 2012 22:46:19 PDT
Received: from magenta.juniper.net (172.17.27.123) by P-EMHUB02-HQ.jnpr.net
	(172.24.192.33) with Microsoft SMTP Server (TLS) id 8.3.213.0;
	Mon, 20 Aug 2012 22:44:27 -0700
Received: from chaos.jnpr.net (chaos.jnpr.net [172.24.29.229])	by
	magenta.juniper.net (8.11.3/8.11.3) with ESMTP id q7L5iRh75647;
	Mon, 20 Aug 2012 22:44:27 -0700 (PDT)	(envelope-from sjg@juniper.net)
Received: from chaos.jnpr.net (localhost [127.0.0.1])	by chaos.jnpr.net
	(Postfix) with ESMTP id 4486F58085;
	Mon, 20 Aug 2012 22:44:27 -0700 (PDT)
To: John Baldwin <jhb@freebsd.org>
In-Reply-To: <201207301119.49002.jhb@freebsd.org>
References: <201207180557.q6I5vheM034018@svn.freebsd.org>
	<201207301119.49002.jhb@freebsd.org>
Comments: In-reply-to: John Baldwin <jhb@freebsd.org>
	message dated "Mon, 30 Jul 2012 11:19:48 -0400."
From: "Simon J. Gerraty" <sjg@juniper.net>
X-Mailer: MH-E 7.82+cvs; nmh 1.3; GNU Emacs 22.3.1
Date: Mon, 20 Aug 2012 22:44:27 -0700
Message-ID: <20120821054427.4486F58085@chaos.jnpr.net>
MIME-Version: 1.0
Content-Type: text/plain
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org, "David E. O'Brien" <obrien@freebsd.org>
Subject: Re: svn commit: r238563 - head/gnu/usr.bin/groff/tmac
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 21 Aug 2012 05:46:19 -0000


On Mon, 30 Jul 2012 11:19:48 -0400, John Baldwin writes:
>> @@ -68,7 +68,7 @@ beforeinstall:
>>  	cd ${.CURDIR}; \
>>  	    ${INSTALL} -o ${TMACOWN} -g ${TMACGRP} -m ${TMACMODE} \
>>  	    koi8-r.tmac hyphen.ru ${DESTDIR}${TMACDIR}
>> -	cd ${.OBJDIR}
>> +	cd ${.OBJDIR};
>
>Isn't this a nop now?  That is, it changes the working directory in a temporar
>y
>shell that immediately exits?

If a shell is used, yes.
Even in compat mode, bmake attempts to avoid the shell, so absent a clue
(like ';') it attempts - and fails direct exection.
A cd like that by itself generally makes no sense (as everyone has noted
;-)

The ';' was a minimal change to ensure consistent behavior b/w the two
makes, but re-working the target to avoid the need for that cd would be
better - as noted just now in response to Ruslan.

Thanks
--sjg