From owner-dev-commits-src-all@freebsd.org Sat Jan 9 18:15:59 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 1369E4DE87F; Sat, 9 Jan 2021 18:15:59 +0000 (UTC) (envelope-from andriy.gapon@uabsd.com) Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4DCp7K01D9z3q1J; Sat, 9 Jan 2021 18:15:56 +0000 (UTC) (envelope-from andriy.gapon@uabsd.com) X-Originating-IP: 195.64.148.76 Received: from [192.168.0.24] (unknown [195.64.148.76]) (Authenticated sender: andriy.gapon@uabsd.com) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 861CE1BF206; Sat, 9 Jan 2021 18:15:51 +0000 (UTC) Subject: Re: git: 82c7abe7785b - main - The "unsigned" type is the same like "unsigned int". To: Hans Petter Selasky , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202101081137.108Bbs7N013971@gitrepo.freebsd.org> From: Andriy Gapon Message-ID: <1d08f668-bd19-dd77-01b8-e138209865d9@uabsd.com> Date: Sat, 9 Jan 2021 20:15:49 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <202101081137.108Bbs7N013971@gitrepo.freebsd.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4DCp7K01D9z3q1J X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of andriy.gapon@uabsd.com designates 217.70.183.201 as permitted sender) smtp.mailfrom=andriy.gapon@uabsd.com X-Spamd-Result: default: False [-1.40 / 15.00]; RCVD_TLS_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; NEURAL_SPAM_SHORT(1.00)[1.000]; HAS_XOIP(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; R_SPF_ALLOW(-0.20)[+ip4:217.70.183.192/28]; ARC_NA(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; SPAMHAUS_ZRD(0.00)[217.70.183.201:from:127.0.2.255]; RWL_MAILSPIKE_POSSIBLE(0.00)[217.70.183.201:from]; DMARC_NA(0.00)[uabsd.com]; RBL_DBL_DONT_QUERY_IPS(0.00)[217.70.183.201:from]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:29169, ipnet:217.70.176.0/20, country:FR]; RCVD_COUNT_TWO(0.00)[2]; MAILMAN_DEST(0.00)[dev-commits-src-all,dev-commits-src-main]; RCVD_IN_DNSWL_LOW(-0.10)[217.70.183.201:from] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 09 Jan 2021 18:15:59 -0000 On 2021-01-08 13:37, Hans Petter Selasky wrote: > The branch main has been updated by hselasky: > > URL: https://cgit.FreeBSD.org/src/commit/?id=82c7abe7785bd8aeb290d91f80ddeb31e81407a5 > > commit 82c7abe7785bd8aeb290d91f80ddeb31e81407a5 > Author: Hans Petter Selasky > AuthorDate: 2021-01-08 10:58:10 +0000 > Commit: Hans Petter Selasky > CommitDate: 2021-01-08 11:35:54 +0000 > > The "unsigned" type is the same like "unsigned int". > > MFC after: 1 week > Sponsored by: Mellanox Technologies // NVIDIA Networking > --- > sys/dev/mlx5/mlx5_core/mlx5_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sys/dev/mlx5/mlx5_core/mlx5_main.c b/sys/dev/mlx5/mlx5_core/mlx5_main.c > index d0b4027165ea..40cba09106f0 100644 > --- a/sys/dev/mlx5/mlx5_core/mlx5_main.c > +++ b/sys/dev/mlx5/mlx5_core/mlx5_main.c > @@ -708,7 +708,7 @@ static int wait_fw_init(struct mlx5_core_dev *dev, u32 max_wait_mili, > if (warn_time_mili && time_after(jiffies, warn)) { > mlx5_core_warn(dev, > "Waiting for FW initialization, timeout abort in %u s\n", > - (unsigned int)(jiffies_to_msecs(end - warn) / 1000)); > + (unsigned)(jiffies_to_msecs(end - warn) / 1000)); I am not sure that we actually prefer "unsigned" over "unsigned int". If you just wanted to make the line a bit shorter then u_int is what is typically used in FreeBSD code. > warn = jiffies + msecs_to_jiffies(warn_time_mili); > } > msleep(FW_INIT_WAIT_MS); >