From owner-freebsd-geom@FreeBSD.ORG Wed Aug 18 19:34:39 2010 Return-Path: Delivered-To: freebsd-geom@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F398D106564A; Wed, 18 Aug 2010 19:34:38 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id 52D6E8FC0A; Wed, 18 Aug 2010 19:34:37 +0000 (UTC) Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id o7IIwWSg059719 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 18 Aug 2010 21:58:32 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.4/8.14.4) with ESMTP id o7IIwWwL017366; Wed, 18 Aug 2010 21:58:32 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.4/8.14.4/Submit) id o7IIwWZf017365; Wed, 18 Aug 2010 21:58:32 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Wed, 18 Aug 2010 21:58:31 +0300 From: Kostik Belousov To: Oliver Fromme Message-ID: <20100818185831.GX2396@deviant.kiev.zoral.com.ua> References: <201008181650.o7IGo3vu096176@freefall.freebsd.org> <201008181706.o7IH6Q3q042332@lurza.secnetix.de> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="b6tME5Uow9dgAUD7" Content-Disposition: inline In-Reply-To: <201008181706.o7IH6Q3q042332@lurza.secnetix.de> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-2.2 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_50, DNS_FROM_OPENWHOIS autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: walter@pelissero.de, bug-followup@freebsd.org, freebsd-geom@freebsd.org Subject: Re: kern/149762: volume labels with rogue characters X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Aug 2010 19:34:39 -0000 --b6tME5Uow9dgAUD7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 18, 2010 at 07:06:26PM +0200, Oliver Fromme wrote: > Oliver Fromme wrote: > > I have reviewed the patch (the second one from the followup), > > and it looks good to me, except for a few minor style(9) > > issues, and one type problem: By default, char is unsigned, > ^^^^^^^^^^^^^^^^^^ > > so the comparisons p <=3D ' ' and p > '~' probably don't do > > what you expect. >=20 > I'm sorry, I meant signed, of course. > You need to specify "unsigned char" if you want it to be unsigned. Signedness of char is implementation-depended. It is signed on x86-oids, and unsigned on powerpc, AFAIR. --b6tME5Uow9dgAUD7 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (FreeBSD) iEYEARECAAYFAkxsLVcACgkQC3+MBN1Mb4jcDQCfUYofBvJScewmXBYPLljLETSO 798An0wmSPW4dbr4fReYCvPaN/9AbLdl =sCVM -----END PGP SIGNATURE----- --b6tME5Uow9dgAUD7--