From owner-cvs-src@FreeBSD.ORG Thu Jul 12 07:59:44 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 78B1416A473; Thu, 12 Jul 2007 07:59:44 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42]) by mx1.freebsd.org (Postfix) with ESMTP id 1E97013C483; Thu, 12 Jul 2007 07:59:43 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [209.31.154.41]) by cyrus.watson.org (Postfix) with ESMTP id 3C6A4482BD; Thu, 12 Jul 2007 03:59:42 -0400 (EDT) Date: Thu, 12 Jul 2007 08:59:42 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Jack F Vogel In-Reply-To: <200707112303.l6BN3HPu010363@repoman.freebsd.org> Message-ID: <20070712085707.G68820@fledge.watson.org> References: <200707112303.l6BN3HPu010363@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/ixgbe LICENSE ixgbe.c ixgbe.h ixgbe_82598.c ixgbe_api.c ixgbe_api.h ixgbe_common.c ixgbe_common.h ixgbe_osdep.h ixgbe_phy.c ixgbe_phy.h ixgbe_type.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Jul 2007 07:59:44 -0000 On Wed, 11 Jul 2007, Jack F Vogel wrote: > jfv 2007-07-11 23:03:17 UTC > > FreeBSD src repository > > Added files: > sys/dev/ixgbe LICENSE ixgbe.c ixgbe.h ixgbe_82598.c > ixgbe_api.c ixgbe_api.h ixgbe_common.c > ixgbe_common.h ixgbe_osdep.h ixgbe_phy.c > ixgbe_phy.h ixgbe_type.h > Log: > Add the actual source too :) This commit message leaves a lot to be desired, especially for 1.1 revisions. I think you should consider a forced commit that mentions something more than that the files are source code -- perhaps a 2-3 level sentence summary of what the actual change meant. Remember that changes on other files, such as the conf files you touched in the earlier commit, won't appear in "cvs log" of these files. Robert N M Watson Computer Laboratory University of Cambridge