From owner-cvs-all Mon Jan 22 16:26:24 2001 Delivered-To: cvs-all@freebsd.org Received: from pike.osd.bsdi.com (unknown [204.216.28.222]) by hub.freebsd.org (Postfix) with ESMTP id 2460237B401; Mon, 22 Jan 2001 16:26:05 -0800 (PST) Received: from foo.osd.bsdi.com (root@foo.osd.bsdi.com [204.216.28.137]) by pike.osd.bsdi.com (8.11.1/8.9.3) with ESMTP id f0N0Q3x16577; Mon, 22 Jan 2001 16:26:03 -0800 (PST) (envelope-from jhb@foo.osd.bsdi.com) Received: (from jhb@localhost) by foo.osd.bsdi.com (8.11.1/8.11.1) id f0N0PdT11888; Mon, 22 Jan 2001 16:25:39 -0800 (PST) (envelope-from jhb) Message-ID: X-Mailer: XFMail 1.4.0 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: Date: Mon, 22 Jan 2001 16:25:39 -0800 (PST) Organization: BSD, Inc. From: John Baldwin To: Dag-Erling Smorgrav Subject: Re: cvs commit: src/sys/netinet ip_dummynet.c Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, Luigi Rizzo Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On 23-Jan-01 Dag-Erling Smorgrav wrote: > Luigi Rizzo writes: >> Log: >> Change critical section protection for dummynet from splnet() to >> splimp() -- we need it because dummynet can be invoked by the >> bridging code at splimp(). > > This has the net effect of replacing one no-op with another: > > root@des ~# egrep 'spl(imp|net)' /sys/sys/systm.h > static __inline intrmask_t splimp(void) { return 0; } > static __inline intrmask_t splnet(void) { return 0; } > > DES It does apply to -stable however, and since this code is not MP safe, it will help to ensure that when it is converted away from mutexes, the coders in question will be aware of what types of things they may need to protect. -- John Baldwin -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.Baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message