From owner-freebsd-hackers@FreeBSD.ORG Sun Jun 19 08:50:46 2011 Return-Path: Delivered-To: hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 22756106566C for ; Sun, 19 Jun 2011 08:50:46 +0000 (UTC) (envelope-from utisoft@gmail.com) Received: from mail-iw0-f182.google.com (mail-iw0-f182.google.com [209.85.214.182]) by mx1.freebsd.org (Postfix) with ESMTP id DC9B88FC0A for ; Sun, 19 Jun 2011 08:50:45 +0000 (UTC) Received: by iwr19 with SMTP id 19so3127458iwr.13 for ; Sun, 19 Jun 2011 01:50:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:in-reply-to:references:from :date:x-google-sender-auth:message-id:subject:to:cc:content-type; bh=HAiox1gdILdUQwH8RL7XNQ6Bi2XxzudnYSHWpQ+suVw=; b=v8QykK6HoIG2mfn8y7SNqWskNmdYkMMw7/ioJsrxB4UfuMCCKh/eAH6yk8oZWpDzN6 S9tScv5dtjG5aQGUsrQ8sGQAftiDJ3/cCc+X3CGDZ2ksn1AQa+zoymutPpuI//PRhmhO Bssb6YN+GmXNh8PWzoyIx23MQcBIEx8qCIjDs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; b=TPVnL18aDRjh1FKj0xvaZvFMz8KyxIjxjGVq8qQZw+PXpmXpo0nQKGlDRiRvWnSTGL cXu2YOFJM+tstaR2W9t5einapdQ65gC7pd9HYiaTcTbp0GNdVk4JVshyZagluJTIOLEG Y1833FHcv7AbEfClDSundB4W1B2eXgFMgro7I= Received: by 10.231.116.1 with SMTP id k1mr3919980ibq.120.1308473445048; Sun, 19 Jun 2011 01:50:45 -0700 (PDT) MIME-Version: 1.0 Sender: utisoft@gmail.com Received: by 10.231.49.193 with HTTP; Sun, 19 Jun 2011 01:50:15 -0700 (PDT) In-Reply-To: <379A724C-4458-4E5C-81E9-CF125666E203@FreeBSD.org> References: <379A724C-4458-4E5C-81E9-CF125666E203@FreeBSD.org> From: Chris Rees Date: Sun, 19 Jun 2011 09:50:15 +0100 X-Google-Sender-Auth: AATCOvp9bONmNtetarw8Cmzb6pk Message-ID: To: Henrik Brix Andersen Content-Type: text/plain; charset=ISO-8859-1 Cc: hackers@freebsd.org Subject: Re: CONF class of files X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Jun 2011 08:50:46 -0000 On 19 June 2011 09:15, Henrik Brix Andersen wrote: > Hi Chris, > > On Jun 17, 2011, at 18:40, Chris Rees wrote: >> Macros are being tested for bsd.port.mk that use a new class of files, >> in the same vein as the BINOWN variables I have introduced CONFOWN, >> CONFGRP, CONFMODE and CONFDIR. >> >> Please would someone review and give an opinion on [1]? > > Shouldn't $CONFDIR be set to ${PREFIX}/etc/ instead of /etc? > > Also, if we define $CONFDIR, we should use it everywhere in bsd.*.mk where we currently use some form of */etc/* - otherwise we will get a mismatch if $CONFDIR is changed from the default. > CONFDIR is for base, not ports, just like most other stuff in that file. Have a look at the other DIR variables. Chris