From owner-svn-ports-head@FreeBSD.ORG  Fri Sep 12 06:14:13 2014
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 9C992F4B;
 Fri, 12 Sep 2014 06:14:13 +0000 (UTC)
Received: from shepard.synsport.net (mail.synsport.com [208.69.230.148])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 72194DA6;
 Fri, 12 Sep 2014 06:14:12 +0000 (UTC)
Received: from [10.31.9.144] (unknown [213.225.137.129])
 (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
 (No client certificate requested)
 by shepard.synsport.net (Postfix) with ESMTP id 0774B438BD;
 Fri, 12 Sep 2014 01:13:59 -0500 (CDT)
Message-ID: <54128F1C.8040904@marino.st>
Date: Fri, 12 Sep 2014 08:13:48 +0200
From: John Marino <freebsd.contact@marino.st>
Reply-To: marino@freebsd.org
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:24.0) Gecko/20100101 Thunderbird/24.5.0
MIME-Version: 1.0
To: Bryan Drewery <bdrewery@FreeBSD.org>, ports-committers@freebsd.org, 
 svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject: Re: svn commit: r367994 - head/Keywords
References: <201409112311.s8BNBmDl017809@svn.freebsd.org>
In-Reply-To: <201409112311.s8BNBmDl017809@svn.freebsd.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 12 Sep 2014 06:14:13 -0000

On 9/12/2014 01:11, Bryan Drewery wrote:
> Author: bdrewery
> Date: Thu Sep 11 23:11:48 2014
> New Revision: 367994
> URL: http://svnweb.freebsd.org/changeset/ports/367994
> QAT: https://qat.redports.org/buildarchive/r367994/
> 
> Log:
>   @sample: Alert user that there is a stale file to be removed.
>   
>   Submitted by:	amdmi3
>   With hat:	portmgr
> 
> Modified:
>   head/Keywords/sample.ucl
>   head/Keywords/sample.yaml
> 
> Modified: head/Keywords/sample.ucl
> ==============================================================================
> --- head/Keywords/sample.ucl	Thu Sep 11 22:30:43 2014	(r367993)
> +++ head/Keywords/sample.ucl	Thu Sep 11 23:11:48 2014	(r367994)
> @@ -33,5 +33,7 @@ pre-deinstall: <<EOD
>    target_file="${sample_file%.sample}"
>    if cmp -s "${target_file}" "${sample_file}"; then
>      rm -f "${target_file}"
> +  else
> +    echo "You may need to manually remove ${target_file} if it's no longer needed."
>    fi
>  EOD
> 
> Modified: head/Keywords/sample.yaml
> ==============================================================================
> --- head/Keywords/sample.yaml	Thu Sep 11 22:30:43 2014	(r367993)
> +++ head/Keywords/sample.yaml	Thu Sep 11 23:11:48 2014	(r367994)
> @@ -32,4 +32,6 @@ pre-deinstall: |
>    target_file="${sample_file%.sample}"
>    if cmp -s "${target_file}" "${sample_file}"; then
>      rm -f "${target_file}"
> +  else
> +    echo "You may need to manually remove ${target_file} if it's no longer needed."
>    fi
> 


Is this message going to show when packages are upgraded too?  If an
upgrade is a deinstall of old version followed by installation of new
version, I would think it would.

I'm just wondering if this message is going to be unnecessary more often
than not....

John