From owner-freebsd-threads@FreeBSD.ORG Fri Nov 27 21:32:05 2009 Return-Path: Delivered-To: threads@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9F26E1065670; Fri, 27 Nov 2009 21:32:05 +0000 (UTC) (envelope-from eischen@vigrid.com) Received: from mail.netplex.net (mail.netplex.net [204.213.176.10]) by mx1.freebsd.org (Postfix) with ESMTP id 57EBC8FC19; Fri, 27 Nov 2009 21:32:05 +0000 (UTC) Received: from [10.48.14.27] (mobile-166-137-136-050.mycingular.net [166.137.136.50]) (authenticated bits=0) by mail.netplex.net (8.14.3/8.14.3/NETPLEX) with ESMTP id nARLJh0A017210 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT); Fri, 27 Nov 2009 16:19:49 -0500 (EST) X-Virus-Scanned: by AMaViS and Clam AntiVirus (mail.netplex.net) X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.2 (mail.netplex.net [204.213.176.10]); Fri, 27 Nov 2009 16:19:55 -0500 (EST) References: <1259298918.1608.19.camel@shumai.marcuscom.com> <20091127131242.GA2368@deviant.kiev.zoral.com.ua> <1259349248.1608.36.camel@shumai.marcuscom.com> Message-Id: <4AF1E295-0524-4C39-94CD-9A12D574C64D@vigrid.com> From: Daniel Eischen To: Joe Marcus Clarke In-Reply-To: <1259349248.1608.36.camel@shumai.marcuscom.com> Content-Type: text/plain; charset=us-ascii; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit X-Mailer: iPhone Mail (7D11) Mime-Version: 1.0 (iPhone Mail 7D11) Date: Fri, 27 Nov 2009 16:19:38 -0500 Cc: "threads@freebsd.org" Subject: Re: [PATCH] Add missing pthread_condattr_{init, destroy} stubs to libc X-BeenThere: freebsd-threads@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Threading on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Nov 2009 21:32:05 -0000 On Nov 27, 2009, at 2:14 PM, Joe Marcus Clarke wrote: > On Fri, 2009-11-27 at 15:12 +0200, Kostik Belousov wrote: >> On Fri, Nov 27, 2009 at 12:15:18AM -0500, Joe Marcus Clarke wrote: >>> I would like permission to commit this patch which adds missing >>> pthread_condattr_{init,destroy} symbols to libc. I think I did the >>> symbol addition correctly (and it seems to work). Without this, the >>> weak symbols added in the libpthread-stubs port conflict with >>> those in >>> libthr, and applications with use these symbols can crash. >>> >>> I have temporarily hacked libpthread-stubs to fix this, but I really >>> feel these stubs should be added to libc. I've also copied kib as >>> he >>> has been kind enough to review my work in the past. Thanks. >>> >>> http://www.marcuscom.com/downloads/stubs.diff >> >> It is FBSD_1.2 version that we use for symbols added after HEAD >> become >> CURRENT-9. > > Done. I don't think the symbols belong in FBSD_1.2. They already exist in libthr in a previous namespace. If you use FBSD_1.2, then you probably need to bump them in libthr and libc_r, and add compatible symbols (no problem there since there are no differences) for the previous versions. Still not sure why libc needs all libpthread stubs. Shouldn't be necessary. -- DE