From owner-freebsd-chat Sun Nov 24 17: 2:53 2002 Delivered-To: freebsd-chat@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7C23B37B401 for ; Sun, 24 Nov 2002 17:02:52 -0800 (PST) Received: from mailsrv.otenet.gr (mailsrv.otenet.gr [195.170.0.5]) by mx1.FreeBSD.org (Postfix) with ESMTP id 15BF943E91 for ; Sun, 24 Nov 2002 17:02:51 -0800 (PST) (envelope-from keramida@ceid.upatras.gr) Received: from gothmog.gr (patr530-b147.otenet.gr [212.205.244.155]) by mailsrv.otenet.gr (8.12.6/8.12.6) with ESMTP id gAP12lYh018798; Mon, 25 Nov 2002 03:02:48 +0200 (EET) Received: from gothmog.gr (gothmog [127.0.0.1]) by gothmog.gr (8.12.6/8.12.6) with ESMTP id gAP12iLP017353; Mon, 25 Nov 2002 03:02:44 +0200 (EET) (envelope-from keramida@ceid.upatras.gr) Received: (from keramida@localhost) by gothmog.gr (8.12.6/8.12.6/Submit) id gAP12hBU017352; Mon, 25 Nov 2002 03:02:43 +0200 (EET) (envelope-from keramida@ceid.upatras.gr) Date: Mon, 25 Nov 2002 03:02:42 +0200 From: Giorgos Keramidas To: Terry Lambert Cc: freebsd-chat@FreeBSD.ORG Subject: Re: Style(9) question Message-ID: <20021125010242.GE15728@gothmog.gr> References: <20021122193040.GA23078@dogma.freebsd-uk.eu.org> <20021122214405.GA11011@HAL9000.homeunix.com> <8gof8g83w4.f8g@localhost.localdomain> <20021124090603.GA3172@HAL9000.homeunix.com> <20021124100846.GC51850@raggedclown.net> <20021124162717.GA576@gothmog.gr> <3DE1739B.5AD2AEA7@mindspring.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3DE1739B.5AD2AEA7@mindspring.com> Sender: owner-freebsd-chat@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org On 2002-11-24 16:49, Terry Lambert wrote: > Giorgos Keramidas wrote: > > On 2002-11-24 11:08, Cliff Sarginson wrote: > > > Can someone tell me if working code has ever been rejected from FreeBSD > > > sources because it grossly violated the style guidelines ? > > > > Not really "rejected", but if you troll the PR database for a while, > > you will notice followups to the spirit of ``This looks fine, but it > > doesn't fit the style of the affected sources. Can you please fix > > this, and post the new patch in a followup?'' > > How about just committing the fix, and filing a "style PR" against > the working code, instead of having style(9) compliant broken code? That makes the PR databas grow linearly in relation to the number of submitted PRs that have ``style issues''. I am more in favor of fixing any style issues, then commiting the fix, and closing the PR with a notice to the spirit of "I have changed the diff a bitt, because of `foo', and have committed it in revision x.y.z of `bar'." This way both the submitter and people who read the bug report in the future, can quickly spot the commit and see what was done differently. Why it was done differently, is what should be noted when the PR closes. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-chat" in the body of the message