From owner-freebsd-current@FreeBSD.ORG Tue Jan 31 15:19:13 2012 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6FF3E1065670 for ; Tue, 31 Jan 2012 15:19:13 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 448178FC15 for ; Tue, 31 Jan 2012 15:19:13 +0000 (UTC) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [96.47.65.170]) by cyrus.watson.org (Postfix) with ESMTPSA id EF19546B0C; Tue, 31 Jan 2012 10:19:12 -0500 (EST) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 823F6B93E; Tue, 31 Jan 2012 10:19:12 -0500 (EST) From: John Baldwin To: freebsd-current@freebsd.org Date: Tue, 31 Jan 2012 10:05:16 -0500 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p10; KDE/4.5.5; amd64; ; ) References: <1327945445.1686.36.camel@revolution.hippie.lan> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201201311005.16099.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Tue, 31 Jan 2012 10:19:12 -0500 (EST) Cc: Ian Lepore , Max Khon Subject: Re: FILTER_SCHEDULE_THREAD is not a bit-value X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Jan 2012 15:19:13 -0000 On Tuesday, January 31, 2012 3:57:26 am Max Khon wrote: > No, the text does not imply that only one of the values is supposed to > be returned (where did you see it). See also KASSERT checks in > intr_event_handle() -- they clearly show that the intention was to > allow FILTER_HANDLED and FILTER_SCHEDULE_THREAD to be returned > simultaneously. That was the original plan, but I now plan to no longer allow that. I think I posted a thread to that effect on arch@ several months ago. However, in some patches I have to rework ithreads, I remove the bitmask bits and make the return value a simple enum of distinct values. Also, your patch is not really correct I think, note that that code is only in the !INTR_FITLER case, and we don't allow you to OR together those two values in the INTR_FILTER case. -- John Baldwin