From owner-svn-src-all@freebsd.org Sat Jan 27 23:09:03 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 50720EC92E8 for ; Sat, 27 Jan 2018 23:09:03 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from pmta2.delivery6.ore.mailhop.org (pmta2.delivery6.ore.mailhop.org [54.200.129.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id BF7047EE45 for ; Sat, 27 Jan 2018 23:09:02 +0000 (UTC) (envelope-from ian@freebsd.org) X-MHO-User: 0c514b55-03b7-11e8-b951-f99fef315fd9 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound2.ore.mailhop.org (Halon) with ESMTPSA id 0c514b55-03b7-11e8-b951-f99fef315fd9; Sat, 27 Jan 2018 23:08:56 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id w0RN8xgh003213; Sat, 27 Jan 2018 16:08:59 -0700 (MST) (envelope-from ian@freebsd.org) Message-ID: <1517094539.1517.9.camel@freebsd.org> Subject: Re: svn commit: r328486 - head/usr.bin/fortune/fortune From: Ian Lepore To: Conrad Meyer , Pedro Giffuni Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Sat, 27 Jan 2018 16:08:59 -0700 In-Reply-To: References: <201801271743.w0RHh9io022619@repo.freebsd.org> <1f1eb186-8f7b-6ec9-0970-d8b82b909e7b@FreeBSD.org> Content-Type: text/plain; charset="iso-8859-13" X-Mailer: Evolution 3.18.5.1 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Jan 2018 23:09:03 -0000 On Sat, 2018-01-27 at 22:56 +0000, Conrad Meyer wrote: > I don˙t think dragonfly has anything to do with this?  If you˙re > converting > bool increments to setting true values in FreeBSD, use > ´true.ˇ  That˙s all > there is to it. > > Best, > Conrad style(9) emphasizes internal consistancy in several places.  The uppercase TRUE/FALSE is currently the style within that code, so it makes sense to stick with it.  If a (somewhat gratuitous) conversion to the new style is made, it should be a separate commit just for that, emphasizing that it changes just style and not functionality. -- Ian