From owner-svn-src-head@freebsd.org Mon Jun 3 16:24:43 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9477515B634C; Mon, 3 Jun 2019 16:24:43 +0000 (UTC) (envelope-from zeising@freebsd.org) Received: from mail.daemonic.se (mail.daemonic.se [IPv6:2607:f740:d:20::25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 2C27188D4D; Mon, 3 Jun 2019 16:24:43 +0000 (UTC) (envelope-from zeising@freebsd.org) Received: from cid.daemonic.se (localhost [IPv6:::1]) by mail.daemonic.se (Postfix) with ESMTP id 45HgPN59Kqz3c7W; Mon, 3 Jun 2019 16:24:40 +0000 (UTC) X-Virus-Scanned: amavisd-new at daemonic.se Received: from mail.daemonic.se ([127.0.0.1]) (using TLS with cipher ECDHE-RSA-AES128-GCM-SHA256) by cid.daemonic.se (mailscanner.daemonic.se [127.0.0.1]) (amavisd-new, port 10587) with ESMTPS id 1NdwpaS5r9xW; Mon, 3 Jun 2019 16:24:40 +0000 (UTC) Received: from vivi.daemonic.se (vivi.daemonic.se [IPv6:2001:470:dca9:2::4]) by mail.daemonic.se (Postfix) with ESMTPSA id 45HgPM6Xdpz3c7V; Mon, 3 Jun 2019 16:24:39 +0000 (UTC) Subject: Re: svn commit: r348355 - head/sys/dev/iicbus To: Andriy Gapon , Ian Lepore , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Cc: jmd@freebsd.org References: <201905290908.x4T98L89066643@repo.freebsd.org> <75cec0b83709f48bbd52e2444d7af17569093f60.camel@freebsd.org> From: Niclas Zeising Message-ID: <10eb223b-5c18-99a0-4eb5-97acd9f91807@freebsd.org> Date: Mon, 3 Jun 2019 18:24:31 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 2C27188D4D X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.99 / 15.00]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.99)[-0.989,0]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Jun 2019 16:24:43 -0000 On 2019-06-03 17:19, Andriy Gapon wrote: > On 03/06/2019 17:52, Ian Lepore wrote: >> Please don't. We still have a situation where nobody has shown a >> runtime failure at all. This build failure could be fixed by simply >> defining a do-nothing iicbus_set_nostop() function if a quick fix is >> needed. > > Well, I am quite certain that the run-time failure will follow after the build > time failure is fixed. > >> Putting this nostop concept into code that is shared by many drivers is >> an abomination. We have exactly one driver that needs this >> functionality, so the right fix is to implement it wholly within that >> one driver. I'll put together a diff for that. > > That's true that we have just one such driver. > At the same time, the "no stop" (or rather, repeated start) behavior makes more > sense. If stop+start between transfers are needed then that can be done with > multiple calls to iicbus_transfer. If multiple messages are given to > iicbus_transfer, then it's reasonable to assume that a repeated started is > wanted between them. But it would be a big change to review and, if needed, fix > or tidy up all code that uses iicbus_transfer. So, iicbus_set_nostop() could be > just a small step towards the bigger goal. > > But I really don't have a strong opinion. > Fixing drm2 directly is just as good for me as iicbus_set_nostop. > Hi! From my perspective, either solution is fine, as long as the drm-legacy drivers keep on working, and I get some help fixing the issue. Is there any way we can revert this change while we're discussing the best solution to this? Regards -- Niclas Zeising