From nobody Tue Dec 13 14:34:19 2022 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NWgxC0pHwz4jjKx; Tue, 13 Dec 2022 14:34:23 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mx.blih.net (mx.blih.net [212.83.155.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mx.blih.net", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4NWgx91vmMz3nCd; Tue, 13 Dec 2022 14:34:21 +0000 (UTC) (envelope-from manu@bidouilliste.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bidouilliste.com header.s=mx header.b=jCnXzUQt; spf=pass (mx1.freebsd.org: domain of manu@bidouilliste.com designates 212.83.155.74 as permitted sender) smtp.mailfrom=manu@bidouilliste.com; dmarc=pass (policy=none) header.from=bidouilliste.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bidouilliste.com; s=mx; t=1670942060; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DrTrJw/txPqyB6f187CIA/rwC0w0k2seXMjcxBBJ17A=; b=jCnXzUQt9ccg9has4eOWteStUdMykMAz0AB5a/qjUazrGAmXUHRH0+QR+5ZYDEFYcyd0zV Nn942juDwtAjIQDz4JEGTMewYYr33qf+UIl3c9B0fsQfVOEm/8WwUMnK+FbSTm3LV4jPUr FXs/BHBqdPAnR4ym8cJ5n/vJWTQ/mgk= Received: from skull.home.blih.net (lfbn-lyo-1-2174-135.w90-66.abo.wanadoo.fr [90.66.97.135]) by mx.blih.net (OpenSMTPD) with ESMTPSA id a4d73a38 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Tue, 13 Dec 2022 14:34:20 +0000 (UTC) Date: Tue, 13 Dec 2022 15:34:19 +0100 From: Emmanuel Vadot To: Jan Beich Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: 799245580a71 - main - graphics/mesa: Do not add USE_LDCONFIG for every mesa ports Message-Id: <20221213153419.6539c65f366bac385064ddb4@bidouilliste.com> In-Reply-To: <359n-t7v2-wny@FreeBSD.org> References: <202212081901.2B8J1frs012470@gitrepo.freebsd.org> <359n-t7v2-wny@FreeBSD.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; amd64-portbld-freebsd14.0) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-3.50 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-0.998]; DMARC_POLICY_ALLOW(-0.50)[bidouilliste.com,none]; MV_CASE(0.50)[]; R_DKIM_ALLOW(-0.20)[bidouilliste.com:s=mx]; R_SPF_ALLOW(-0.20)[+ip4:212.83.155.74/32:c]; MIME_GOOD(-0.10)[text/plain]; ASN(0.00)[asn:12876, ipnet:212.83.128.0/19, country:FR]; MLMMJ_DEST(0.00)[dev-commits-ports-all@FreeBSD.org,dev-commits-ports-main@FreeBSD.org]; MIME_TRACE(0.00)[0:+]; DKIM_TRACE(0.00)[bidouilliste.com:+]; FROM_EQ_ENVFROM(0.00)[]; ARC_NA(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FREEFALL_USER(0.00)[manu]; RCVD_VIA_SMTP_AUTH(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; RCVD_TLS_ALL(0.00)[] X-Rspamd-Queue-Id: 4NWgx91vmMz3nCd X-Spamd-Bar: --- X-ThisMailContainsUnwantedMimeParts: N On Sat, 10 Dec 2022 19:46:09 +0100 Jan Beich wrote: > Emmanuel Vadot writes: > > > Not every mesa ports provides shared libraries intented for dynamic uses > > so stop running ldconfig script for those ports. > [...] > > diff --git a/graphics/mesa-dri/Makefile b/graphics/mesa-dri/Makefile > > index ac87f4cef889..e4fe1b570261 100644 > > --- a/graphics/mesa-dri/Makefile > > +++ b/graphics/mesa-dri/Makefile > > @@ -26,6 +26,8 @@ ZSTD_DESC= Use ZSTD for shader cache > > ZSTD_LIB_DEPENDS= libzstd.so:archivers/zstd > > ZSTD_MESON_ENABLED= zstd > > > > +USE_LDCONFIG= yes > > OpenGL drivers in mesa-dri lack headers, SONAME and cannot be used by ld(1) > via -l due to missing "lib" prefix (unless using -l: syntax > which is generally useful to force static linking of a specific lib). > For dlopen(3) mesa-libs uses ${PREFIX}/lib/dri (or LIBGL_DRIVERS_PATH) > and vulkan-loader with ${PREFIX}/share/vulkan/icd.d/*.json (or > VK_ICD_FILENAMES) instead of ldconfig(8) hints. > > lang/clover is probably similar as there's no API outside of > devel/ocl-icd using dlopen(3) with ${PREFIX}/etc/OpenCL/vendors/*.icd > > diff --git a/graphics/mesa-dri/Makefile b/graphics/mesa-dri/Makefile > index 956cfb1d6f3e..94c8503053a7 100644 > --- a/graphics/mesa-dri/Makefile > +++ b/graphics/mesa-dri/Makefile > @@ -27,8 +27,6 @@ ZSTD_DESC= Use ZSTD for shader cache > ZSTD_LIB_DEPENDS= libzstd.so:archivers/zstd > ZSTD_MESON_ENABLED= zstd > > -USE_LDCONFIG= yes > - > .include > .include "${.CURDIR:H:H}/graphics/mesa-dri/Makefile.common" > > diff --git a/lang/clover/Makefile b/lang/clover/Makefile > index c8f6dca6412b..c8325d1aad63 100644 > --- a/lang/clover/Makefile > +++ b/lang/clover/Makefile > @@ -20,8 +20,6 @@ LIB_DEPENDS= libOpenCL.so:devel/ocl-icd \ > RUN_DEPENDS= libclc>=0.3.0:devel/libclc \ > opencl>=0:devel/opencl > > -USE_LDCONFIG= yes > - > .include > .include "${.CURDIR:H:H}/graphics/mesa-dri/Makefile.common" > You're right, feel free to commit this. Thanks, -- Emmanuel Vadot