From owner-dev-commits-src-all@freebsd.org Fri Feb 19 04:29:52 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 15B2A53AFF4 for ; Fri, 19 Feb 2021 04:29:52 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qk1-x72b.google.com (mail-qk1-x72b.google.com [IPv6:2607:f8b0:4864:20::72b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DhdsC6r3Zz4rmh for ; Fri, 19 Feb 2021 04:29:51 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qk1-x72b.google.com with SMTP id b14so4524554qkk.0 for ; Thu, 18 Feb 2021 20:29:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=z6cS+ICy5XYIfus1j2z8FyqIYS7e13RM5M2hAqotOAA=; b=h8Nk9ob/KnTfzfHTSVgukFAtCCu1JNQFDvF/QvJZXt5UkcOGb4gxuuLtlxeYJetmSj si1UugfadiGctc/Gfj4FsX6ebbz5QeFQGZKWCm4VsoTiPB2+1r6YLODx6BcsdH+GXYjq gANH3KTwmJr1FpsnsP1TpK6xKYPvyt26R+pBQRN41Tn39hsIfb+IMrWvw3blUNlWQ8KZ On6r+7YC3y9oBYtIthbZ/sTXr1BPrld+/U+Lc+VJ+s+gvwJxDsxqfVA6GQgqft52UX77 AE7eXMg8zOBNVspIuvxJviqmqW075Yrufv635qs+e2GZFIVanAtW59omxSiZV5Lc0vfd YUIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=z6cS+ICy5XYIfus1j2z8FyqIYS7e13RM5M2hAqotOAA=; b=mBiNLHDEdJ1UQt4zJgvYItR4CcfadJFTzqU7HTrXoGb6QEe5ysvxh+7C2bmtrBmTCr U6Zh0h1i3Ieid9PtUPXSiTY3TbqvOsp6TeVNzTuOxwTJSU7zcvs5QUa9agmGkBYnKUwW 5tzMI6yz4sP8qaDmTvPy6jEA/EEiJeqBgiAcgdUvhQVuYT9ovYy72hrnO6RO7POP36en 4rTpmTpSu85rHoOPFyXG+nhoN1/Wh2/CI5LrCTpeVICJYyqG8R0UdU1PTpiqZC8nggl9 Su24AAgU/IEBPzM64vMgwjxA/aHx3HUGo8zWZHnrx+I+hJh/KqjhdjcYea8h3iYt2IKm VEzg== X-Gm-Message-State: AOAM533ue5VZssRiw6i2g0hANBRaRqSfIKyy5Xn9yjyKK38rEahWoF1h ss++EcJglZwewvikhhyQznD7SXDe0/FvEneERBAuaQ== X-Google-Smtp-Source: ABdhPJxIGRn2ago6ap68BGMJZx85S1zrokJ4ZOEljZeGpEfeg6YQCy6zUAVtvHjLBvlZVx8SKaI0EhNN3eAACETuZ5w= X-Received: by 2002:a37:a151:: with SMTP id k78mr7577135qke.359.1613708990904; Thu, 18 Feb 2021 20:29:50 -0800 (PST) MIME-Version: 1.0 References: <202102181251.11ICpheY033790@gitrepo.freebsd.org> <6EF9FDEA-6CE6-4212-B489-B1170EC153EF@gmail.com> In-Reply-To: <6EF9FDEA-6CE6-4212-B489-B1170EC153EF@gmail.com> From: Warner Losh Date: Thu, 18 Feb 2021 21:29:40 -0700 Message-ID: Subject: Re: git: e13e4fa6c4eb - main - fix Navdeeps LINT_NOINET error. To: Enji Cooper Cc: Randall Stewart , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" X-Rspamd-Queue-Id: 4DhdsC6r3Zz4rmh X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Feb 2021 04:29:52 -0000 On Thu, Feb 18, 2021 at 9:02 PM Enji Cooper wrote: > > On Feb 18, 2021, at 4:51 AM, Randall Stewart wrote: > > The branch main has been updated by rrs: > > URL: > https://cgit.FreeBSD.org/src/commit/?id=3De13e4fa6c4eba72de5c4685942de5db= e8f43db73 > > commit e13e4fa6c4eba72de5c4685942de5dbe8f43db73 > Author: Randall Stewart > AuthorDate: 2021-02-18 12:29:12 +0000 > Commit: Randall Stewart > CommitDate: 2021-02-18 12:29:12 +0000 > > fix Navdeeps LINT_NOINET error. > > > Hi Randall, > Could you please reference the commit which caused the breakage, i.e., 0a= 4f851074a3, > next time? It=E2=80=99s really hard to determine what the cause of the br= eakage > is without first understanding that np@FreeBSD.org is the =E2=80=9CNavdee= p=E2=80=9D being > referred to in the commit; having the commit(s) referenced would allow me > to figure out what caused the issue. > Thank you so very much for helping break the build! > Emaste@ has proposed adopting the fairly common 'Fixes: ' metadata item that could be used for this as well as grouping commits for MFC. https://reviews.freebsd.org/D28693 Warner