From owner-svn-ports-head@FreeBSD.ORG Fri Apr 26 20:15:37 2013 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 19816C28; Fri, 26 Apr 2013 20:15:37 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mail-ea0-x22f.google.com (mail-ea0-x22f.google.com [IPv6:2a00:1450:4013:c01::22f]) by mx1.freebsd.org (Postfix) with ESMTP id 285511BFA; Fri, 26 Apr 2013 20:15:36 +0000 (UTC) Received: by mail-ea0-f175.google.com with SMTP id f15so1798786eak.6 for ; Fri, 26 Apr 2013 13:15:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:sender:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=OU/DvAGoKKfqVPkPJeGde58DsRnn5iGW9PS+XvVVigI=; b=vZ5STuxC340REr8k7I3BnigFDvMr4Fv0VxS3IQGVHoOwSbWKRqglX/u8aoifle5xHi X7AI2DRtaY9KWBV6fxiV8uU2IYe0l3i0f8wnlAbK424qTvtdcsn/DvFw6FFefzLShO2p MrcAYilvtm8yyU1wWmxhigx4ekY8VSOhWKt4qWGgNrdQ2ecbHAodRqJWKOzttByT2v6T lv08FZm3LTWtNVqCLzN06m6AgPK8bzGwNBLZLiOlBHugI2LJUIV2evSqdt/wJ/HoFn5z eVvYdbBDX92QITl8d9liq1KNeBovzKg9e6fn/GF0Wo79AtD1qMSdcITM1SfalPyec+n5 1Puw== X-Received: by 10.14.105.1 with SMTP id j1mr46439301eeg.6.1367007335330; Fri, 26 Apr 2013 13:15:35 -0700 (PDT) Received: from ithaqua.etoilebsd.net (ithaqua.etoilebsd.net. [37.59.37.188]) by mx.google.com with ESMTPSA id bj2sm17937554eeb.1.2013.04.26.13.15.33 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Fri, 26 Apr 2013 13:15:34 -0700 (PDT) Sender: Baptiste Daroussin Date: Fri, 26 Apr 2013 22:15:32 +0200 From: Baptiste Daroussin To: Sunpoet Po-Chuan Hsieh Subject: Re: svn commit: r316281 - head/Mk Message-ID: <20130426201532.GE74139@ithaqua.etoilebsd.net> References: <201304222213.r3MMDFec026886@svn.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="C94crkcyjafcjHxo" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Apr 2013 20:15:37 -0000 --C94crkcyjafcjHxo Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Apr 27, 2013 at 03:48:01AM +0800, Sunpoet Po-Chuan Hsieh wrote: > On Tue, Apr 23, 2013 at 6:13 AM, Baptiste Daroussin wro= te: >=20 > > Author: bapt > > Date: Mon Apr 22 22:13:14 2013 > > New Revision: 316281 > > URL: http://svnweb.freebsd.org/changeset/ports/316281 > > > > Log: > > Remove old links while creating the new packages > > Force creation of the symlink for pkgng to avoid failure if the link > > already exists > > > > Submitted by: ohauer@ > > > > Modified: > > head/Mk/bsd.pkgng.mk > > > > Modified: head/Mk/bsd.pkgng.mk > > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- head/Mk/bsd.pkgng.mk Mon Apr 22 22:06:34 2013 (r31628= 0) > > +++ head/Mk/bsd.pkgng.mk Mon Apr 22 22:13:14 2013 (r31628= 1) > > @@ -258,6 +258,9 @@ do-package: ${TMPPLIST} > > fi; \ > > fi; \ > > fi; > > + @for cat in ${CATEGORIES}; do \ > > + ${RM} -fv > > ${PACKAGES}/$$cat/${PKGNAMEPREFIX}${PORTNAME}*${PKG_SUFX} ; \ > > + done > > >=20 > Please revert/modify this change! > It has 2 problems. >=20 > First, it would remove other *correct* links. >=20 > % cd /usr/ports/x11/xorg > % make package > ... > =3D=3D=3D> Checking if x11/xorg already installed > =3D=3D=3D> Registering installation for xorg-7.5.2 > Installing xorg-7.5.2... done > =3D=3D=3D> Building package for xorg-7.5.2 > /usr/ports/packages/x11/xorg-7.5.2.txz > /usr/ports/packages/x11/xorg-cf-files-1.0.4.txz > /usr/ports/packages/x11/xorg-libraries-7.5.1.txz > /usr/ports/packages/x11/xorg-macros-1.16.1.txz > Creating package for xorg-7.5.2 This is not the problem but the goal with pkgng we need no more links anywh= ere except for pkgng itseld because the bootstrap in base relies on it. >=20 > Second, it's very strange to show some filenames/links without any > user-friendly messages. Users may not know that they are outdated links > removed by bsd.pkgng.mk. >=20 > e.g. while updating mail/postfix from 2.9.5 to 2.10, I got: > =3D=3D=3D> Building package for postfix-2.10.0,1 > /usr/ports/packages/mail/postfix-2.9.5,1.txz > /usr/ports/packages/ipv6/postfix-2.9.5,1.txz > Creating package for postfix-2.10.0,1 >=20 You are right here, I'll remove the -v. regards, Bapt --C94crkcyjafcjHxo Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlF64GMACgkQ8kTtMUmk6Eze7QCgoWIG8XOdvUiqrnx2bCmNh7NN FWgAoICwlOJI3bdSuh1Vgw3B8Ol7zZws =rlCx -----END PGP SIGNATURE----- --C94crkcyjafcjHxo--