From owner-svn-src-head@FreeBSD.ORG  Wed Jul 17 08:41:39 2013
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id A84907ED
 for <svn-src-head@freebsd.org>; Wed, 17 Jul 2013 08:41:39 +0000 (UTC)
 (envelope-from mailer-daemon@vniz.net)
Received: from mail-lb0-f172.google.com (mail-lb0-f172.google.com
 [209.85.217.172]) by mx1.freebsd.org (Postfix) with ESMTP id 30884D3B
 for <svn-src-head@freebsd.org>; Wed, 17 Jul 2013 08:41:38 +0000 (UTC)
Received: by mail-lb0-f172.google.com with SMTP id v20so1374098lbc.17
 for <svn-src-head@freebsd.org>; Wed, 17 Jul 2013 01:41:37 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=google.com; s=20120113;
 h=message-id:date:from:user-agent:mime-version:to:cc:subject
 :references:in-reply-to:openpgp:content-type
 :content-transfer-encoding:x-gm-message-state;
 bh=YhpaggDKqZsmynfZNgx0YvqRRMcVuyrB2+gM7+5ph3w=;
 b=hnk6hiLeRn99PKeATxNQQbCA6j8DACVny8xUIhXMd7/Pj82MbDp/lKknVmQENewRPb
 6det9whF51rHQvKgl/mCl4vDGMc6EuVTSoXu1v3zJKWZNht/vCucufgmbbIOyXn0CoMh
 pmbfQSyZUbHY2fX5N+q79I53xZb3zs+/v5t78+X9RW+3IRSAepNosYnA7W5IEwQYypRX
 YzgtoFoIPqMt+G4TrxRVFh4jacoKxDgdmytRqleP1kpDFGCWIerBuE38qjGyHYW79N2+
 OYSKiOiHNFZSExypxyPUkPAnOxDWd5A9an97lneFpDBlKwXLjZcVWssacFMuOSo/Ux58
 HxPA==
X-Received: by 10.112.19.162 with SMTP id g2mr2834231lbe.9.1374050497757;
 Wed, 17 Jul 2013 01:41:37 -0700 (PDT)
Received: from [192.168.1.2] ([89.169.173.68])
 by mx.google.com with ESMTPSA id am8sm1991956lac.1.2013.07.17.01.41.36
 for <multiple recipients>
 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);
 Wed, 17 Jul 2013 01:41:37 -0700 (PDT)
Message-ID: <51E658BD.9020700@freebsd.org>
Date: Wed, 17 Jul 2013 12:41:33 +0400
From: Andrey Chernov <ache@freebsd.org>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:17.0) Gecko/20130620 Thunderbird/17.0.7
MIME-Version: 1.0
To: Andriy Gapon <avg@FreeBSD.org>
Subject: Re: svn commit: r253380 - head/lib/libc/stdlib
References: <201307160726.r6G7QlwE045679@svn.freebsd.org>
 <51E61950.5090206@freebsd.org> <51E62219.1090006@freebsd.org>
 <51E62B37.8080900@freebsd.org> <51E6576C.6010000@FreeBSD.org>
In-Reply-To: <51E6576C.6010000@FreeBSD.org>
OpenPGP: id=964474DD
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Gm-Message-State: ALoCoQlHa4ueQ6+W7HCHymVlaLdRaZ6l/0VvNjjHxxth4P9IAzzdoYOFZqGoDt33ceaAD9iek9iF
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
 src-committers@FreeBSD.org
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 17 Jul 2013 08:41:39 -0000

On 17.07.2013 12:35, Andriy Gapon wrote:
>>>>> -		env = stpcpy(envVars[envNdx].name, name);
>>>>> +		env = stpncpy(envVars[envNdx].name, name, nameLen);
>>>>>  		if ((envVars[envNdx].name)[nameLen] != '=')
>>>>>  			env = stpcpy(env, "=");
>> Microoptimized:
>>
>> env = stpncpy(envVars[envNdx].name, name, nameLen);
>> *env++ = '=';
>>
> 
> In fact, I think that the currently committed code is not functionally broken,
> just weird.

No. The bad thing is that current code increments "env" pointer
unpredictable (depending on junk). And the value of variable is written
to that "env" pointer later will be off by one sometimes.

-- 
http://ache.vniz.net/
bitcoin:1G6ugdNY6e5jx1GVnAU2ntj2NEfmjKG85r