Date: Tue, 1 May 2018 14:49:36 -0400 From: David Cross <dcrosstech@gmail.com> To: Kyle Evans <kevans@freebsd.org> Cc: Warner Losh <imp@bsdimp.com>, FreeBSD Hackers <freebsd-hackers@freebsd.org>, Devin Teske <dteske@freebsd.org> Subject: Re: Bug 207069 (loader password kills boot) Message-ID: <BBFD5A99-23FA-462B-AA23-EFF5B75C56EA@gmail.com> In-Reply-To: <CACNAnaGmHK1WoXHX2rvJR=50p%2B1gX72M7%2BM-KH5YzET=e48_UQ@mail.gmail.com> References: <7630266D-D078-41B3-BC27-32EBF65540C4@gmail.com> <CACNAnaEEd_DoJg_9B=Y2GuL=R40ShTA27fgXis3jMiSgVdN9-A@mail.gmail.com> <CANCZdfr0pRiN08ZVn%2B2x%2BTk6suAbkg7Ui_X-9S=E14WfqDFMYg@mail.gmail.com> <CACNAnaGmHK1WoXHX2rvJR=50p%2B1gX72M7%2BM-KH5YzET=e48_UQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
=46rom my investigation when I wrote the patch originally the problem is (as= I recall, its been awhile) the forth dictionary space is limited so parts a= re flushed out (that is the only section at the top) additional dictionarie= s are then explicitly loaded (the also sections. The load_kernel and load_mo= dules are needed from the support-functions dictionaries As for why this is now needed here, there was a change made ~2 years ago to d= efer loading the kernel until the system was just about to boot (after beast= ie menu vs before). Autoboot assumes that kernel is loaded and will not load= for you. Making it load for you conflicts with the menu loading it. So it p= assword is enabled menu and kernel loading doesn=E2=80=99t happen. This reat= ores that and puts it right before autoboot (which is a C portion of loader)= (Going off of memory from ~2 years ago) Apologies for naming the patch works for me. This wasn=E2=80=99t just slap i= t in where it worked, i spent a good amount of time digging into what change= d, why, and to maintain the desired flow, > On May 1, 2018, at 14:22, Kyle Evans <kevans@freebsd.org> wrote: >=20 >> On Tue, May 1, 2018 at 1:17 PM, Warner Losh <imp@bsdimp.com> wrote: >>=20 >>=20 >>> On Tue, May 1, 2018 at 12:12 PM, Kyle Evans <kevans@freebsd.org> wrote: >>>=20 >>>> On Tue, May 1, 2018 at 1:07 PM, David Cross <dcrosstech@gmail.com> wrot= e: >>>> The aforementioned bug has been open for over 2 years, with attached an= d >>>> tested patches. At least one other has commented. >>>>=20 >>>> Could we please have it for 11.2/12.0? >>>=20 >>> Hi, >>>=20 >>> CC'ing Devin, our local Forth-fu-fighter. If it looks ok to Devin, one >>> of us should go ahead and shuffle this through. >>=20 >>=20 >> Yes. I've looked at this code a fair amount, and I don't understand why t= his >> is needed and why it would make things work. Since it is a security thing= , >> I'm very reluctant to push it in absent better understanding of why it >> works. >>=20 >=20 > Right, it also confuses me. =3D) >=20 > When I was implementing this stuff for Lua, autoboot DTRT as long as > module_path is setup correctly -- this is probably the part that's > missing since IIRC that's usually done in menu setup (that doesn't > happen here). >=20 > I'm not sure if this the right way to fix it in Forth-land, though.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?BBFD5A99-23FA-462B-AA23-EFF5B75C56EA>