From owner-svn-ports-head@freebsd.org Sat Mar 10 01:58:39 2018 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 997ECF3C7CF; Sat, 10 Mar 2018 01:58:38 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1E4E87A729; Sat, 10 Mar 2018 01:58:38 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (unknown [127.0.1.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by freefall.freebsd.org (Postfix) with ESMTPS id E0882158C7; Sat, 10 Mar 2018 01:58:37 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id DD47942E; Sat, 10 Mar 2018 01:58:36 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id OLU74tTNNtpf; Sat, 10 Mar 2018 01:58:34 +0000 (UTC) Subject: Re: svn commit: r464037 - head/irc/znc DKIM-Filter: OpenDKIM Filter v2.10.3 mail.xzibition.com 82C21422 To: "Danilo G. Baio" , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, Eitan Adler References: <201803100016.w2A0GnR8013646@repo.freebsd.org> From: Bryan Drewery Openpgp: id=F9173CB2C3AAEA7A5C8A1F0935D771BB6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Organization: FreeBSD Message-ID: Date: Fri, 9 Mar 2018 17:58:31 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <201803100016.w2A0GnR8013646@repo.freebsd.org> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="PcP8agBravegaycizJzoTWJMkav5lLIAD" X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Mar 2018 01:58:39 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --PcP8agBravegaycizJzoTWJMkav5lLIAD Content-Type: multipart/mixed; boundary="SFWhbX3WXAd9WBHq8XWSjXRXsy3Ro960Q"; protected-headers="v1" From: Bryan Drewery To: "Danilo G. Baio" , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, Eitan Adler Message-ID: Subject: Re: svn commit: r464037 - head/irc/znc References: <201803100016.w2A0GnR8013646@repo.freebsd.org> In-Reply-To: <201803100016.w2A0GnR8013646@repo.freebsd.org> --SFWhbX3WXAd9WBHq8XWSjXRXsy3Ro960Q Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 3/9/2018 4:16 PM, Danilo G. Baio wrote: > Author: dbaio > Date: Sat Mar 10 00:16:49 2018 > New Revision: 464037 > URL: https://svnweb.freebsd.org/changeset/ports/464037 >=20 > Log: > irc/znc: Set option CHARSET as default > =20 > ZNC has supported character encodings in core since 1.6.0 and > building/enabling charset is the recommended way. > =20 > While here, sort Makefile and change URLs to use HTTPs. > =20 > Submitted by: eadler (via email) >=20 > Modified: > head/irc/znc/Makefile > head/irc/znc/pkg-descr >=20 > Modified: head/irc/znc/Makefile > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/irc/znc/Makefile Fri Mar 9 22:46:22 2018 (r464036) > +++ head/irc/znc/Makefile Sat Mar 10 00:16:49 2018 (r464037) > @@ -3,9 +3,10 @@ > =20 > PORTNAME=3D znc > PORTVERSION=3D 1.6.6 > +PORTREVISION=3D 1 > CATEGORIES=3D irc ipv6 > -MASTER_SITES=3D http://znc.in/releases/ \ > - http://znc.in/releases/archive/ > +MASTER_SITES=3D https://znc.in/releases/ \ > + https://znc.in/releases/archive/ > =20 This is a note in general, not specifically at you. But https for distfiles only achieves 2 things: 1. Privacy against someone snooping that you are downloading ZNC (is it really that important?) but still can see your DNS and connections to the ZNC site... and 2. It breaks proxy caching. So I don't think MASTER_SITES should be converted to https in general. There's this odd push for it lately but I don't see the benefit. --=20 Regards, Bryan Drewery --SFWhbX3WXAd9WBHq8XWSjXRXsy3Ro960Q-- --PcP8agBravegaycizJzoTWJMkav5lLIAD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJaozvHAAoJEDXXcbtuRpfPCtoH/jxHSWw4n84bzvhNleyjUO1Y Hxj06EjiABu4U5xg2LPWSWvVWDqIVgc8ue6BQqMKKczdCTkzKX/fQEGyC9flPQlC igbrc1iyhJBI+cOQgT8dZgFbz4r6UMK1a505lhMPRbqJ+cAkrGACGCj9oa4NQfNi CX+kU44GfK7nNFAUL/pKDvQTJNY/M0jLaTzKcIkMm0e1b1YQWhW16h5I9atQKycn 9XqT8mpJR6XlwbaoBgLP2N8SAI/N/kcVq7J69hoKeBQ7XqwBfjyr6ARN/PBQ2f9z /WwtQ/ZAgY0wQd+U1u2Nnt6j+FBkU/7a9QJK86KHKHMFjvBsz25bfTBc/a7ql7Q= =Iyp/ -----END PGP SIGNATURE----- --PcP8agBravegaycizJzoTWJMkav5lLIAD--