From owner-freebsd-current Tue Nov 26 18:33:08 1996 Return-Path: owner-current Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id SAA18780 for current-outgoing; Tue, 26 Nov 1996 18:33:08 -0800 (PST) Received: from agora.rdrop.com (root@agora.rdrop.com [199.2.210.241]) by freefall.freebsd.org (8.7.5/8.7.3) with SMTP id SAA18775 for ; Tue, 26 Nov 1996 18:33:06 -0800 (PST) Received: from phaeton.artisoft.com by agora.rdrop.com with smtp (Smail3.1.29.1 #17) id m0vSZo3-0008uRC; Tue, 26 Nov 96 18:32 PST Received: (from terry@localhost) by phaeton.artisoft.com (8.6.11/8.6.9) id TAA26348; Tue, 26 Nov 1996 19:12:32 -0700 From: Terry Lambert Message-Id: <199611270212.TAA26348@phaeton.artisoft.com> Subject: Re: Dosboot and bcc To: joerg_wunsch@uriah.heep.sax.de Date: Tue, 26 Nov 1996 19:12:32 -0700 (MST) Cc: freebsd-current@FreeBSD.org In-Reply-To: <199611270139.CAA23113@uriah.heep.sax.de> from "J Wunsch" at Nov 27, 96 02:39:51 am X-Mailer: ELM [version 2.4 PL24] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-current@FreeBSD.org X-Loop: FreeBSD.org Precedence: bulk > > This is so frigging bogus. > ... > > The ufs code should use "uint64", not "long long". > ...and Terry should use grep. > > j@uriah 606% grep 'long *long' /sys/ufs/*/* > j@uriah 607% > > Christian has been referring to system _header_ files here since he > wants to re-use the system's native files for the dosboot stuff, as > opposed to whack his own set. He will need his own definition of uint64. Obviously one that does not use "long long". However, ig you grep for the 64 bit fields in the ufs/ffs headers, and then you grep for their references, you will see that they directly reference the values as if they were atomic types. This is the bogus part of the FS code, since it should not be dependent on the definition of a 64bit type to be atomic. So rather than me using grep once, you should have used grep twice. FWIW: The same thing applies to system time references, which should potentially be function call wrappers, since not all systems have a global variable containing the current time. Regards, Terry Lambert terry@lambert.org --- Any opinions in this posting are my own and not those of my present or previous employers.