From owner-svn-src-head@freebsd.org Sat Mar 4 21:14:52 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 43B43CF5328; Sat, 4 Mar 2017 21:14:52 +0000 (UTC) (envelope-from cy.schubert@komquats.com) Received: from smtp-out-no.shaw.ca (smtp-out-no.shaw.ca [64.59.134.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id EC41D1E15; Sat, 4 Mar 2017 21:14:51 +0000 (UTC) (envelope-from cy.schubert@komquats.com) Received: from spqr.komquats.com ([96.50.22.10]) by shaw.ca with SMTP id kH0kczcRvkevukH0lcl8Fa; Sat, 04 Mar 2017 14:14:44 -0700 X-Authority-Analysis: v=2.2 cv=BLbDlBYG c=1 sm=1 tr=0 a=jvE2nwUzI0ECrNeyr98KWA==:117 a=jvE2nwUzI0ECrNeyr98KWA==:17 a=kj9zAlcOel0A:10 a=6Iz7jQTuP9IA:10 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=gO0ro-WWNe3wqWzS9koA:9 a=CjuIK1q_8ugA:10 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTPS id 1D1738C8; Sat, 4 Mar 2017 13:14:42 -0800 (PST) Received: from slippy (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id v24LEfqZ098918; Sat, 4 Mar 2017 13:14:41 -0800 (PST) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201703042114.v24LEfqZ098918@slippy.cwsent.com> X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.6 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Ngie Cooper cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r314676 - in head/usr.sbin/amd: amd libamu In-Reply-To: Message from Ngie Cooper of "Sat, 04 Mar 2017 20:35:34 +0000." <201703042035.v24KZYUv058554@repo.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Sat, 04 Mar 2017 13:14:41 -0800 X-CMAE-Envelope: MS4wfF+tsGH6fS4zWIOOWyLFKaOiEijFX1ALaYqwgD97EZcVDpCoc8DyFFEP9nwDdxsQm+XZEYcmfI5ObLo8NxZU3Wf/zE41uZ8D/P0XFEgjvdgpVZZeO5Nv rZyboLCivWhYlmAD5HCea7tXnsWUq4lX74RkpX1yRHWDhOBfUzCEUP5vOLjsF8QU/ouDOAFgXc9KjGr/oSWJx702QUmQ9LyI7lrw85AYXJSf9GdUoEny3BtL /jGBzkHSrTAp4uxYCH4ZYwcHIyB5prStGtbUnCR1vt75hsaP1VbDd5i6NEvl2IhA X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Mar 2017 21:14:52 -0000 In message <201703042035.v24KZYUv058554@repo.freebsd.org>, Ngie Cooper writes: > Author: ngie > Date: Sat Mar 4 20:35:34 2017 > New Revision: 314676 > URL: https://svnweb.freebsd.org/changeset/base/314676 > > Log: > Fix build after r314656 > > Some of the changes I introduced to use .ALLSRC were correct in spirit, > but incorrect in reality -- in particular, ../Makefile.inc hadn't been > pulled in via bsd.init.mk (via bsd.lib.mk, bsd.prog.mk), so the value > of .ALLSRC (evaluated immediately) was empty. .include bsd.init.mk > explicitly so we can be certain that the values used as dependencies in > the targets are defined when the target recipe has been evaluated. > > Reminder: thou shalt separate out separate functional changes before > committing them. > > (YUGE) Pointyhat to: ngie > In collaboration with: bdrewery > MFC after: 1 month > Reported by: Jenkins, cy, ler,O. Hartmann , Michael Butler Actually, I didn't report anything. I simply replied to O. Hartmann's email that it was failing to link to rpcsvc. Good to see it's fixed. The NFS RPC relationship makes amd a little tricky. -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.