Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 25 Mar 2011 22:51:42 GMT
From:      Fabian Keil <fk@fabiankeil.de>
To:        freebsd-gnats-submit@FreeBSD.org
Subject:   ports/155938: Unbreak sysutils/pftop on 9.X
Message-ID:  <201103252251.p2PMpglu013044@red.freebsd.org>
Resent-Message-ID: <201103252300.p2PN0OMd032894@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         155938
>Category:       ports
>Synopsis:       Unbreak sysutils/pftop on 9.X
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Mar 25 23:00:24 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator:     Fabian Keil
>Release:        9.0-CURRENT
>Organization:
>Environment:
FreeBSD r500.local 9.0-CURRENT FreeBSD 9.0-CURRENT #279 r+e9d52e4: Thu Mar 24 23:01:13 CET 2011     fk@r500.local:/usr/obj/usr/src/sys/ZOEY  amd64

>Description:
sysutils/pftop has recently been marked as broken for 9.X,
the attached patch unbreaks it again.

I only tested it on 9.0-CURRENT amd64, but I expect it to
continue working on other versions, too.
>How-To-Repeat:
Try to build the port on 9.0-CURRENT.
>Fix:


Patch attached with submission follows:

--- .zfs/snapshot/2011-03-25/sysutils/pftop/Makefile	2011-03-25 21:55:02.000000000 +0100
+++ sysutils/pftop/Makefile	2011-03-25 23:43:18.686796644 +0100
@@ -29,7 +29,7 @@
 .endif
 
 .if ${OSVERSION} >= 900000
-BROKEN=		does not compile on 9.X
+CFLAGS+=	-DHAVE_SNPRINTF=1 -DHAVE_VSNPRINTF=1
 .endif
 
 MAKE_ENV+=	__MAKE_CONF=/dev/null
@@ -41,6 +41,7 @@
 	    ${WRKSRC}/engine.c
 	@${REINPLACE_CMD} -e 's|__dead|__dead2|g' ${WRKSRC}/sf-gencode.h
 	@${REINPLACE_CMD} -e 's|__dead|__dead2|g' ${WRKSRC}/sf-gencode.c
+	@${REINPLACE_CMD} -e 's|__inline__|static __inline__|g' ${WRKSRC}/pftop.c
 	@${REINPLACE_CMD} -e 's|#include <net/if_pflog.h>||g' \
 	    ${WRKSRC}/sf-gencode.c
 


>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201103252251.p2PMpglu013044>